From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4GS0H/2Sd2MEjAAAbAwnHQ (envelope-from ) for ; Fri, 18 Nov 2022 15:13:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id kAN6H/2Sd2NULgAAauVa8A (envelope-from ) for ; Fri, 18 Nov 2022 15:13:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A71794EC for ; Fri, 18 Nov 2022 15:13:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow278-00052W-OQ; Fri, 18 Nov 2022 09:13:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow274-0004xx-RN for guix-patches@gnu.org; Fri, 18 Nov 2022 09:13:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow274-0008Jk-Fk for guix-patches@gnu.org; Fri, 18 Nov 2022 09:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow274-0000ft-Ax for guix-patches@gnu.org; Fri, 18 Nov 2022 09:13:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59188] [PATCH 0/4] gnu: node-lts: Update to 18.12.1. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Nov 2022 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mekeor Melire Cc: hako@ultrarare.space, Christopher Baines , 59188@debbugs.gnu.org Received: via spool by 59188-submit@debbugs.gnu.org id=B59188.16687807402538 (code B ref 59188); Fri, 18 Nov 2022 14:13:02 +0000 Received: (at 59188) by debbugs.gnu.org; 18 Nov 2022 14:12:20 +0000 Received: from localhost ([127.0.0.1]:35903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow26O-0000es-Gn for submit@debbugs.gnu.org; Fri, 18 Nov 2022 09:12:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow26M-0000eg-Gn for 59188@debbugs.gnu.org; Fri, 18 Nov 2022 09:12:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow26G-0008Dk-Ik; Fri, 18 Nov 2022 09:12:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=VbfEQd4C45v9cVELS7Y25QeZiitnyhoCxbhmgHB4ohU=; b=ehYEU8TP9/XxgE1VGQFw V+D36hB3JKQdJQKeIlmilHU/OGYmTH7VGY8ZlQg4kztSB5qR6gYUKJ72nVBbsvO0nQHfseveUHMBv UbHv5yCdiJXoDwiSKMza0Sz44xxgoOzD0Y0VSTuyOObR+g4TpmHmTc4t8sAVvA1hIIEe/8kKcAx9x 2V+KI+O8WlBEFCcKJBDVnDQSUcGEIHIxQzAqXw5BbcxgDb49cqol/yKkhU9I5XsgfnKyYVQnAnvdn C4lHbEUIJF1esI1CxmJgo/d/XMrIdLqr2leOooxoA05bPrhsfUJysQv7hJJ+r027YvDaVNAjA2O1c VXyR+rrP+tg4Kw==; Received: from [193.50.110.147] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow26G-0004LE-5e; Fri, 18 Nov 2022 09:12:12 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87zgcq79ml.fsf@posteo.de> Date: Fri, 18 Nov 2022 15:12:10 +0100 In-Reply-To: <87zgcq79ml.fsf@posteo.de> (Mekeor Melire's message of "Wed, 16 Nov 2022 23:31:24 +0000") Message-ID: <87bkp4bbd1.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668780797; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VbfEQd4C45v9cVELS7Y25QeZiitnyhoCxbhmgHB4ohU=; b=iu3tYurO71ZD4AcJIP2SPn2uj+L+yU/7s4NRprRGRBIxgtQjJUvWYBlJryAUS5kvQgDFrP 2KiV0v0UfkQWJfiFUHbwvl9YS2nI7MtF/vyRKxSmVebXGopLirb6Qsso1IuGlFJmguNDts klXk2GfySOhv92vIEX5F22HaKqPJjcMvRCVHKtBvWRATt3BqnkbEnUUApTFOmRjolxyeXM RRRuAnI7TVOFtt1/x6YVBHq1N8yW9vdS5dW9sp/UK45nm5KS6s9neHrsipNSImUtjNp6X1 u5/i2KAMswF/i5YeYE0erJSnGTTB+iA99T/2UVTd2mSMmiHIGo+AstKO7wcfxg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668780797; a=rsa-sha256; cv=none; b=JgBf79+azBcq69ofe0iH2BRixcWSy96JhtbhHm6uGYIrFbna9F8ftfCdrw3Z/u5XPllbNI Jw1Jn5vQ5nrl73FCJmTlQLFVQwpqwoHTB9JIK25VTKoCEJLhCAAcuRjprbgyIy/pDdpbvg QPYrBPx+X3joGLuI4g0ts4YwboM2VtIgbwCYMX4KNRJBwyI0WNgUudvtXvBqHf4kSeW/pH whNhlOCrjkcYa8ftxQweGhhq5vR73TMRjMdYd1dvsmD8QdqU6Wco9SeV//7uP0yZZjnmId lmLSvBGSF1I/Je8ATTmlvukFED1fkzBQ2CR7KyjUOn/iNVQ4SYXDR3MZWTvgUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ehYEU8TP; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ehYEU8TP; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4A71794EC X-Spam-Score: -2.42 X-Migadu-Scanner: scn1.migadu.com X-TUID: mpNGnjx9gU1D Hi, Mekeor Melire skribis: > As I said in the other thread, I'd suggest to decline the 53414 (which > updates node to version 16.x) in favor of this patch-series (which > updates to 18.x). That is because it'll save us work since there'll only > be a single package-breaking upgrade (instead of two). Sounds good to me. > For this submission to be merged, I'd guess we should: > > 1. Check if we want to adapt some patches from Debian, listed here: > https://sources.debian.org/patches/nodejs/18.12.1+dfsg-2/ > E.g. the "dfsg/privacy_breach.patch" looks good. Yes, but that can be done separately I guess. > 2. Make sure that packages, which depend on node, still build (and run) > fine. I'm not sure how to do this. Do we need a branch for this? It depends. Hilton, were you able to build everything returned by =E2=80=98guix refresh -l node=E2=80=99, except perhaps ungoogled-chromium? For some reason didn=E2=80=99t pick it up. Anything we should do to address that, Chris? Otherwise we can indeed create a branch and tell ci.guix to build it, for instance. Thanks, Ludo=E2=80=99.