From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id QHiNKBsOQWTeAgAASxT56A (envelope-from ) for ; Thu, 20 Apr 2023 12:04:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oCyXKBsOQWTSsAAA9RJhRA (envelope-from ) for ; Thu, 20 Apr 2023 12:04:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4560C3A334 for ; Thu, 20 Apr 2023 12:04:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppR94-0007VU-Gv; Thu, 20 Apr 2023 06:04:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppR91-0007O4-Oi for guix-patches@gnu.org; Thu, 20 Apr 2023 06:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppR90-0003Pl-VZ for guix-patches@gnu.org; Thu, 20 Apr 2023 06:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppR90-0004wA-Em for guix-patches@gnu.org; Thu, 20 Apr 2023 06:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#60788] Policy for system tests? Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Apr 2023 10:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60788 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Bruno Victal , 60788@debbugs.gnu.org Received: via spool by 60788-submit@debbugs.gnu.org id=B60788.168198500218908 (code B ref 60788); Thu, 20 Apr 2023 10:04:02 +0000 Received: (at 60788) by debbugs.gnu.org; 20 Apr 2023 10:03:22 +0000 Received: from localhost ([127.0.0.1]:36638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppR8M-0004uu-9f for submit@debbugs.gnu.org; Thu, 20 Apr 2023 06:03:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppR8K-0004uh-JX for 60788@debbugs.gnu.org; Thu, 20 Apr 2023 06:03:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppR8E-00037O-M5; Thu, 20 Apr 2023 06:03:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=oSiOiLkTrEmaMxfXfkVhsHzeezXOoOU/kQ7889sakfY=; b=elmIxUpQPX3IkMBIalsq xUZy9tpuUd1QBpdR8RYWf62wZlHgK0Zks1OFnnNXGDv8PjJQCXjB2p3GkR+Ezw6FYaLcXKs12X2cE 47nrV4OSh8kpYXlG7uAeJruEc8g/1Me7kd9wQ1hTDe4G+BMbjkuebEmxnmSI1njIqUQnNOyfWv2nf 4krNyK6LMIKbLhjD4rQxtqou33Vv9GdcBmaBl4oqM/1GrKmsKrBYtUcBNExLMm4ulorSiD0Fb3eFc StdbLTibDRxVyjOI5MleRTUBk+iZP/VM0k427/xU8RzWx08GGqOmAV+JRP7Tw7R37iNZuah3XGV0f VMnpcvWTzmphyg==; Received: from [193.50.110.118] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppR86-0002hR-NT; Thu, 20 Apr 2023 06:03:14 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <95b646eb6b23dec213cba43b6e4e7ddc4a601d0f.1673640404.git.mirai@makinata.eu> <87edovd8em.fsf_-_@gnu.org> <87cz4ftq5z.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Primidi 1 =?UTF-8?Q?Flor=C3=A9al?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de la Rose X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 20 Apr 2023 12:03:04 +0200 In-Reply-To: <87cz4ftq5z.fsf@gmail.com> (Maxim Cournoyer's message of "Fri, 07 Apr 2023 16:04:24 -0400") Message-ID: <87bkjix44n.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=elmIxUpQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681985051; a=rsa-sha256; cv=none; b=Q3eq+TtoRinMOoFgzTflTd+80H0n6/bL/M6imx/PHSeZ1+fX1iC6zAWbrRE7QzmzqLE0Rb 2Lqj+ZurT6uw6iO41IFvDVNFIaYIjZZtLgR1tZ96IBrlsqgviJ45UepsdlQ9tJqBvkJibj TtgxZyWQIumf0NXCFjTgUQWSX/jjPX47NUMmH60cQFFZHVSpxgMMTtVqFcWT5p6THtE+zm HKeLKF3KuJtny0SHZmLobJE5CPuiraZz7NDunOfajiEpk14wd3sVUsUB4XaSw/zp66+TKr vZAm/aV3R9J/xYAWBKluMglam3hgacIpZs20UqBLcWCC1sDLo0Up4Hu9bbGaFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681985051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=oSiOiLkTrEmaMxfXfkVhsHzeezXOoOU/kQ7889sakfY=; b=ZlXWrpGfX9M/P4tsFJtyh6Mc7aY0XZZIFspcRvtUt4w7JhbmLKQfq6wzP8X380lQuScO1G EeiVAObhjDWhok4VK24+q2e23e1TIyG7CqpITezuLftncxbCZjvODdDspiYOGrKs1vthSS ds+KdQR+ZHnwmRHrLOgJurPW4SxKo35BIWPUpjMPrEfSfTDUYd5o/Kdvj/YaHwuxVxKxxd DdaN+LF4WWw8yo66Hxt4+kKMSFxCK4Hx0sXiP6p30Lr2DfXh3BCEuQs0U0dp/yg+UyACbB VGeblCvOdxVCVNMhs8kEzJkyoWisOlgSwriN6JrTK/dTZPn4h+EDYOzhHlAU/w== X-Migadu-Spam-Score: -2.21 X-Spam-Score: -2.21 X-Migadu-Queue-Id: 4560C3A334 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=elmIxUpQ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: TAjh26PyrsjK Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: [...] >> I think a system test would be nice, we generally require it upfront, >> but since Maxim wrote it can come later, let=E2=80=99s not let it block = this >> patch any longer. > > I didn't mean to lower our standards; I wasn't sure if that policy of > ours was strict, since a few system services do not have corresponding > tests, IIRC. I wary a bit that demanding a system test for each added > service may cause scalability problems in the long run, as each demand a > disk-heavy image to be generated and the test to run in a VM, which > makes it expensive/slow. On the other hand, it's nice to know about any > regressions when they happen rather than on a reboot... Yeah, it=E2=80=99s an unwritten policy; I think we=E2=80=99ve consistently = required it for some time now. It=E2=80=99s useful because otherwise it=E2=80=99s hard= to tell what the status is for a service. (Speaking of which, we do *not* have that policy for Home services, because we don=E2=80=99t even have a test strategy, and that=E2=80=99s some= thing we should fix before it=E2=80=99s too late.) > If we have such a policy, perhaps we should explicit it in > our documented contribution guidelines? Yes! Also, we should split the submission guidelines into different categories: packages, services, doc, core, etc. Ludo=E2=80=99.