From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Simon Tournier <zimon.toutoune@gmail.com>,
Mathieu Othacehe <othacehe@gnu.org>,
Tobias Geerinckx-Rice <me@tobias.gr>,
Ricardo Wurmus <rekado@elephly.net>,
65426-done@debbugs.gnu.org, Christopher Baines <guix@cbaines.net>
Subject: bug#65426: [PATCH v2] lint: Check that (cc-for-target) and friends are used.
Date: Fri, 08 Sep 2023 18:36:43 +0200 [thread overview]
Message-ID: <87bkec4o6c.fsf@gnu.org> (raw)
In-Reply-To: <025525cb01ccce0a9e7a07bc9338423961eaa355.1692626393.git.maximedevos@telenet.be> (Maxime Devos's message of "Mon, 21 Aug 2023 15:59:53 +0200")
Hi Maxime,
Maxime Devos <maximedevos@telenet.be> skribis:
> "CC=gcc" is almost always incorrect; people often just don't
> notice the incorrectness because they are compiling natively.
> For an exception, see tzdata.
>
> "guix style" partially made things worse, so I partially ignored it.
>
> * guix/lint.scm (check-compiler-for-target): New linter.
> * tests/lint.scm
> ("compiler-for-target: unconditional CC=gcc is unacceptable")
> ("compiler-for-target: looks through G-expressions")
> ("compiler-for-target: (cc-for-target) is acceptable")
> ("compiler-for-target: CC=gcc is acceptable when target=#false"):
> Test it.
Finally applied, thanks! It’s a much welcome improvement.
Ludo’.
prev parent reply other threads:[~2023-09-08 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 13:07 [bug#65426] [PATCH] lint: Check that (cc-for-target) and friends are used Maxime Devos
2023-08-21 13:59 ` [bug#65426] [PATCH v2] " Maxime Devos
2023-09-08 16:36 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkec4o6c.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=65426-done@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=maximedevos@telenet.be \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).