From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yP3fLGH3GmVnKwAAG6o9tA:P1 (envelope-from ) for ; Mon, 02 Oct 2023 19:01:21 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yP3fLGH3GmVnKwAAG6o9tA (envelope-from ) for ; Mon, 02 Oct 2023 19:01:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E584549E0 for ; Mon, 2 Oct 2023 19:01:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=N+1R5N4z; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1696266081; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Zji95AD1vcqyZHnhsTawUPVs8/8ExPVkYSWQDs0sd+0=; b=K2r2Y9LHHMkvStKbtypejlzBtpA/VzkGt8R+ByaQz0Uh0c/RY+dCxysWT9M/YJDbrL7j2z vsBhvQmrmmSqnMfk/GqYTNciEIaqQYnem3iqzwJcR1bo7k+8B80fIhBwk19RH8XTTdh40l wKD+BmMFI1YwTnPNFvvZTJrSapNJSmCeQohymY01tmjFAWgir8DYZFA1Dq1Y2+HwKphxPZ u2kHslGn+Ppsze1aLdk3FRSPapmHozfutBiJPjwYyDsYq2eHP+Fpmi0V9KVZ/batg5hzH0 XMLXcUHOmYpILAsFfGHXWlniOEfKy3BrzqU6+LE1XOg1meyAGVCnEsIrXFcS9g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=N+1R5N4z; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1696266081; a=rsa-sha256; cv=none; b=tjnV++I6UjzrWlUsaLLg55LOLZbeyBV4rMXxx+/v3R3VNEky97XzvReVgKaJcPyJ+uGFtT hg6NFjAVxDj0O1iYiqZt49LsqSZdyVQMY9s52W6FwQy5Bujnnx88DRgNpf8SbkDmbmScmC Pg6eKkU6DfflGzMxyE10cOWMlBCj+j9rMb8zg25tjLIrG8mLL6pi7vGIECqnT7AYJVRA3h LiZS8bnC2Se9gJNgCo7LCCLzj6sOdKLSiYsFEdAFHYjVA3s5gXkyPU/AbcxnJaYPzeIcF5 9oEEEz4LOJgs7OQIxCqde+jueeyddeNvYlcYmsPTKcPn1z+o+ObnDbIvkoeooQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qnMHv-0000ZA-Mx; Mon, 02 Oct 2023 13:00:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qnMHm-0000Uz-Uv for guix-patches@gnu.org; Mon, 02 Oct 2023 13:00:51 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qnMHm-0001nd-4z for guix-patches@gnu.org; Mon, 02 Oct 2023 13:00:46 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qnMI2-0000Z9-IE for guix-patches@gnu.org; Mon, 02 Oct 2023 13:01:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63985] [PATCH RFC 0/5] Generic INI serializer & SRFI-171 for define-configuration Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Oct 2023 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 63985@debbugs.gnu.org Received: via spool by 63985-submit@debbugs.gnu.org id=B63985.16962660442135 (code B ref 63985); Mon, 02 Oct 2023 17:01:02 +0000 Received: (at 63985) by debbugs.gnu.org; 2 Oct 2023 17:00:44 +0000 Received: from localhost ([127.0.0.1]:37839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnMHj-0000YM-Of for submit@debbugs.gnu.org; Mon, 02 Oct 2023 13:00:44 -0400 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]:50421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qnMHi-0000Y6-8b for 63985@debbugs.gnu.org; Mon, 02 Oct 2023 13:00:43 -0400 Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-45281e0b1cbso17240137.0 for <63985@debbugs.gnu.org>; Mon, 02 Oct 2023 10:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696266020; x=1696870820; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zji95AD1vcqyZHnhsTawUPVs8/8ExPVkYSWQDs0sd+0=; b=N+1R5N4zwWx68Ikaa0vMrOg3iVpdR5x8mWGOmNL7wiBC9/PdN9n8tvrzrr4UU6OqOR pr6eQPDIEZcesleEL/rT4YFMqEN1IdcHcvrqEboSaiVv8b3f2IWgMrxKKy8BTmuqmWq5 kiUkcRXT3B3H5No4E7+Y/Jvs2ak+SdyfrV1LgsMXmBL8gmIzrSRooaIcGcMVWfl6i/19 0/vmSRyWNjaP9BmsQIMhAVe+gCyUaRmhfmVeiMNJeXds1Eq3bKdXyg/yHqP5zxNVVdSq nQG30FAL7ouv0x+nMTLDCK+1VOk+aaEmhj2gW/ox9wSE1auhIpM+SZEBJzg4EuC4WpGm mQmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696266020; x=1696870820; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zji95AD1vcqyZHnhsTawUPVs8/8ExPVkYSWQDs0sd+0=; b=hMxMZrM067obMsSgXU8oi80Ujdo9aUkX2YjpekV+hEqLcMRwyp8AdFCsLpeuvxygUC pKE5bSPAtSiT/GZMVj2gZeACxAWFxBnxlDG4e4wm9kR5KKzKhWd3dimlVP+Yghg8WHhA mnRY855EC723R8XANlByVm/PWeXoiaJYZVpH1avucT2PdAyA6EBmvX0/ec4ulLABibJZ RumfNqvJjGq/lzcx/WkERj1d+PZCUECTXPqxMySZ+5oht9O0TjmwLLvkVAKN6Fck+LS4 v0+SmxLWGNVIBqRziSubqG2RYljQsb6xMmmlSO72T8qudYc8wJibWVgWju6ZepRWKBym C7Rg== X-Gm-Message-State: AOJu0YzJGS8H/O/8fcPuSW7nLmpU9LeJNcujAs5L2cz+gPTYqxcd/1Vk NTCK108i7wqo5X183BAjMnTCPZPTTUQ= X-Google-Smtp-Source: AGHT+IEhsJsJavWUpBa/pSSAFBaT6XN6bT7PWNvowvCu49/JwvdtjCEe3ZHouZRrwHJ0tEkfiieuuQ== X-Received: by 2002:a67:fd4a:0:b0:452:82c4:d641 with SMTP id g10-20020a67fd4a000000b0045282c4d641mr9712901vsr.31.1696266019684; Mon, 02 Oct 2023 10:00:19 -0700 (PDT) Received: from hurd (dsl-10-136-90.b2b2c.ca. [72.10.136.90]) by smtp.gmail.com with ESMTPSA id o8-20020a0ce408000000b0065b1c26c89asm5779166qvl.145.2023.10.02.10.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 10:00:19 -0700 (PDT) From: Maxim Cournoyer References: <22471a74b258f7169961898eed9e18cee7504f60.1687816734.git.mirai@makinata.eu> Date: Mon, 02 Oct 2023 13:00:17 -0400 In-Reply-To: <22471a74b258f7169961898eed9e18cee7504f60.1687816734.git.mirai@makinata.eu> (Bruno Victal's message of "Mon, 26 Jun 2023 22:59:27 +0100") Message-ID: <87bkdh3qou.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.10 X-Migadu-Scanner: mx2.migadu.com X-Migadu-Queue-Id: 3E584549E0 X-Spam-Score: -5.10 X-TUID: 54iFiG78U/iR Hi, Bruno Victal writes: > * gnu/services/configuration.scm > (define-configuration-helper, normalize-extra-args): Use #f instead of %unset-value. > --- > gnu/services/configuration.scm | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm > index 367b85c1be..dafe72f4fe 100644 > --- a/gnu/services/configuration.scm > +++ b/gnu/services/configuration.scm > @@ -190,32 +190,32 @@ (define (define-configuration-helper serialize? serializer-prefix syn) > (define (normalize-extra-args s) > "Extract and normalize arguments following @var{doc}." > (let loop ((s s) > - (sanitizer* %unset-value) > - (serializer* %unset-value)) > + (sanitizer* #f) > + (serializer* #f)) > (syntax-case s (sanitizer serializer empty-serializer) > (((sanitizer proc) tail ...) > - (if (maybe-value-set? sanitizer*) > - (syntax-violation 'sanitizer "duplicate entry" > - #'proc) > + (if sanitizer* > + (syntax-violation 'sanitizer > + "duplicate entry" #'proc) > (loop #'(tail ...) #'proc serializer*))) > (((serializer proc) tail ...) > - (if (maybe-value-set? serializer*) > - (syntax-violation 'serializer "duplicate or conflicting entry" > - #'proc) > + (if serializer* > + (syntax-violation 'serializer > + "duplicate or conflicting entry" #'proc) > (loop #'(tail ...) sanitizer* #'proc))) > ((empty-serializer tail ...) > - (if (maybe-value-set? serializer*) > + (if serializer* > (syntax-violation 'empty-serializer > "duplicate or conflicting entry" #f) > (loop #'(tail ...) sanitizer* #'empty-serializer))) > (() ; stop condition The above LGTM. > (values (list sanitizer* serializer*))) > ((proc) ; TODO: deprecated, to be removed. > - (null? (filter-map maybe-value-set? (list sanitizer* serializer*))) > + (every not (list sanitizer* serializer*)) Alternatively, using DeMorgan's law: (not (or sanitizer* serializer*)) > (begin > (warning #f (G_ "specifying serializers after documentation is \ > deprecated, use (serializer ~a) instead~%") (syntax->datum #'proc)) > - (values (list %unset-value #'proc))))))) > + (values (list #f #'proc))))))) > > (syntax-case syn () > ((_ stem (field field-type+def doc extra-args ...) ...) > @@ -239,11 +239,11 @@ (define (define-configuration-helper serialize? serializer-prefix syn) > default-value)) > #'((field-type def) ...))) > ((field-sanitizer ...) > - (map maybe-value #'(sanitizer* ...))) > + #'(sanitizer* ...)) > ((field-serializer ...) > (map (lambda (type proc) > (and serialize? > - (or (maybe-value proc) > + (or proc I haven't applied it locally so may be out of context, but how do we ensure here that sanitizer and proc aren't set to #f before calling them? -- Thanks, Maxim