From: Richard Sent <richard@freakingpenguin.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 70148@debbugs.gnu.org
Subject: [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements.
Date: Sat, 04 May 2024 18:44:31 -0400 [thread overview]
Message-ID: <87bk5l42pc.fsf@freakingpenguin.com> (raw)
In-Reply-To: <87wmo9sesk.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 04 May 2024 18:49:31 +0200")
Hi Ludo!
>> Both openrc and sysvinit use guix-daemon.in so daemonize should be
>> required regardless of the init system.
>
> ‘daemonize’ seems to be used by etc/init.d/guix-daemon.in, but not by
> etc/openrc/guix-daemon.in, right?
Correct, I think I got confused by guix-install.sh copying
etc/openrc/guix-daemon to /etc/init.d/guix-daemon. (See the openrc
handler in the $INIT_SYS case statement in sys_enable_guix_daemon()).
Assuming I understand the script; I find shell scripts hard to parse.
> My only concern is if the majority of users (which I assume use systemd)
> would get an error for a missing package they don’t actually need.
>
> Do you think that is a risk or is ‘daemonize’ usually installed “by
> default” even on those systemd distros?
I suspect there's a risk. WSL Debian does not come with daemonize out of
the box so I imagine normal Debian does not either.
If OpenRC/systemd does not require daemonize, there's probably a better way to
handle this. Perhaps a INITD_REQUIRE variable that's only checked
conditionally depending on what init system is detected (aka INIT_SYS).
--
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.
next prev parent reply other threads:[~2024-05-04 22:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 16:14 [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements Richard Sent
2024-05-04 16:49 ` Ludovic Courtès
2024-05-04 22:44 ` Richard Sent [this message]
2024-05-22 14:08 ` Simon Tournier
2024-05-25 13:59 ` Ludovic Courtès
2024-05-29 0:36 ` [bug#70148] [PATCH v2] guix-install.sh: Add unique requirement for sysv init system Richard Sent
2024-06-02 9:45 ` Ludovic Courtès
2024-06-02 14:33 ` Richard Sent
2024-06-04 10:11 ` bug#70148: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk5l42pc.fsf@freakingpenguin.com \
--to=richard@freakingpenguin.com \
--cc=70148@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).