unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 70269@debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul@autistici.org>,
	Sharlatan Hellseher <sharlatanus@gmail.com>,
	Munyoki Kilyungi <me@bonfacemunyoki.com>,
	Lars-Dominik Braun <lars@6xq.net>, jgart <jgart@dismail.de>,
	Marius Bakke <marius@gnu.org>,
	Tanguy Le Carrour <tanguy@bioneland.org>
Subject: [bug#70269] [PATCH] gnu: Add python-pybadges.
Date: Mon, 13 May 2024 07:40:10 +0200	[thread overview]
Message-ID: <87bk5acls5.fsf@ngraves.fr> (raw)
In-Reply-To: <e5ffe23e93f708cb0c5a3f449b16ca36c5033550.1712527982.git.goodoldpaul@autistici.org>

On 2024-04-08 00:13, Giacomo Leidi via Guix-patches via wrote:

> * gnu/packages/python-web.scm (python-pybadges): New variable.
>
> Change-Id: Idd53ddf94b24112015c0a0b82396cf366920417e
> ---
>  gnu/packages/python-web.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 9ad081beb1..da4f019476 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -9123,6 +9123,40 @@ (define-public python-whatthepatch
>       "This package provides a library to parse and apply patches.")
>      (license license:expat)))
>  
> +(define-public python-pybadges
> +  (package
> +    (name "python-pybadges")
> +    (version "3.0.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/google/pybadges")
> +                    (commit (string-append version))))

(string-append with a single string is a bit odd ;)

> +              (file-name (git-file-name name version))
> +              (sha256
> +               "1zgb9idz7m3mzf8wvik0gwmyrxp753axqjv2pab326cr5myj1s4b")))
> +    (build-system pyproject-build-system)
> +    (arguments
> +     (list
> +      #:test-flags
> +      #~'("-k"
> +          ;; Disable network dependent tests.
> +          "not test_changes and not test_not_image_url and not test_http_url")))
> +    (propagated-inputs (list python-jinja2 python-requests))
> +    (native-inputs (list python-flask
> +                         python-fonttools
> +                         python-nox
> +                         python-pillow
> +                         python-pytest
> +                         python-xmldiff))
> +    (home-page "https://github.com/google/pybadges")
> +    (synopsis
> +     "Libbrary and command-line tool for generating Github-style badges")
           ^ typo there
> +    (description
> +     "This package provides @code{python-pybadges}: a library and command-line
> +tool for generating Github-style badges.")

Maybe you can be a bit more descriptive: "as SVG images" in the Github
description is informative. I often also like (but I'm not sure it's a
norm) to write my synopsis as an action statement, such as "Generate
Github-style badges on the command-line".

> +    (license license:asl2.0)))

Otherwise LGTM.

> +
>  (define-public python-grid5000
>    (package
>      (name "python-grid5000")
>
> base-commit: 69951a61a1d8f1f2135ea2dc836738be282b97bc

-- 
Best regards,
Nicolas Graves




  reply	other threads:[~2024-05-13  5:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-07 22:13 [bug#70269] [PATCH] gnu: Add python-pybadges Giacomo Leidi via Guix-patches via
2024-05-13  5:40 ` Nicolas Graves via Guix-patches via [this message]
2024-05-13 17:07   ` paul via Guix-patches via
2024-05-13 17:05 ` [bug#70269] [PATCH v2] " Giacomo Leidi via Guix-patches via
2024-05-31 10:02   ` bug#70269: " Ludovic Courtès
2024-05-14 20:10 ` [bug#70269] QA review for 70269 Nicolas Graves via Guix-patches via
2024-05-15 13:58 ` [bug#70269] Comments Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk5acls5.fsf@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=70269@debbugs.gnu.org \
    --cc=goodoldpaul@autistici.org \
    --cc=jgart@dismail.de \
    --cc=lars@6xq.net \
    --cc=marius@gnu.org \
    --cc=me@bonfacemunyoki.com \
    --cc=ngraves@ngraves.fr \
    --cc=sharlatanus@gmail.com \
    --cc=tanguy@bioneland.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).