unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Dale Mellor <guix-devel-0brg6a@rdmp.org>
Cc: 68869-done@debbugs.gnu.org, rostislav.svoboda@gmail.com
Subject: bug#68869: [PATCH v2] guix: channels: Fix typos.
Date: Mon, 13 May 2024 09:21:28 +0100	[thread overview]
Message-ID: <87bk5a5dh3.fsf@cbaines.net> (raw)
In-Reply-To: <20240512083439.2067537-1-guix-devel-0brg6a@rdmp.org> (Dale Mellor's message of "Sun, 12 May 2024 09:34:29 +0100")

[-- Attachment #1: Type: text/plain, Size: 730 bytes --]

Dale Mellor <guix-devel-0brg6a@rdmp.org> writes:

> From: Rostislav Svoboda <rostislav.svoboda@gmail.com>
>
> * guix/channels.scm (authenticate-channel): Pluralise commit numbers.
>
> Review:
>   * Microscopic documentation change, harmless, but will invoke some i18n
>     activity
>   * Not sure this justifies adding two names to the copyright holders list, if
>     any at all?
>   * Works for me
>
> Reviewed-by: Dale Mellor <guix-devel-0brg6a@rdmp.org>
> Change-Id: I7759607f37405e6d3bd4b7f5958fd11d908db204
> ---
>  guix/channels.scm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Thanks both, I've tweaked the commit message and pushed this to master
as e5fa18b6285c59b6e9f8debe0ffde9ef5055f3a2.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

      reply	other threads:[~2024-05-13  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01 12:42 [bug#68869] [PATCH] channels: Fix typos Rostislav Svoboda
2024-05-12  8:34 ` [bug#68869] [PATCH v2] guix: " Dale Mellor
2024-05-13  8:21   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk5a5dh3.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=68869-done@debbugs.gnu.org \
    --cc=guix-devel-0brg6a@rdmp.org \
    --cc=rostislav.svoboda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).