From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SMNuHEtW1mabSwEAqHPOHw:P1 (envelope-from ) for ; Tue, 03 Sep 2024 00:20:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SMNuHEtW1mabSwEAqHPOHw (envelope-from ) for ; Tue, 03 Sep 2024 02:20:27 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="p2A/35mL"; dkim=fail ("headers rsa verify failed") header.d=zancanaro.id.au header.s=k1 header.b=WqUJUCiW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=zancanaro.id.au (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725322827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8HpbT93fJHjcpnBC+1qc0nWljns2tw/LCMpNTGnhYFY=; b=bV2cXCmQCCpR+QJBxLzPuYAW3gu6V5bzUiR+hgt2SbIKO0DPNQivS5lIbqo3BmzgqWgPk3 XKBTBKgPpmOR05D0mPcwIyVZziFcI3UmckGg/fAE1jl3HFcIliPrYa/SF692ff1rKSU4O1 RxGcqxhWWLMhGvX72JObMSTVeVnZZatGpP6a3lIGBVR1It4dLFYpYUe3rxBxTcNht/8/tt jkWlOIhqG4oDcIU6prUNKsBix0MECIE1M14h7UL2MjM3SOvakYrtgBkKZ8Yk7qKcZWd51q NCBqH6TNhFe9bPBNGjofZqN4PEbGtuCLQRPWmvnVxQ8Ya6y99N6os/+vFLrjvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="p2A/35mL"; dkim=fail ("headers rsa verify failed") header.d=zancanaro.id.au header.s=k1 header.b=WqUJUCiW; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=zancanaro.id.au (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725322827; a=rsa-sha256; cv=none; b=KsGenKgY3gqpCEroBK2OEAX2/n/nlMn5VOb/iUYFvrBUAbKY8BQ7KoS6FDALi+k9zR3JlF DIXILgHaxUaKbGtd0pUe5yoMJ85lVFhP0n2XMLaKhb/hPapCE2MpJx62Yc8XH5EAcfFmAx /ptiGfsjCqt+zFaBAmX3gcYXoEgJmzqT9sx7ftI9GtD3mkmYrO9OGlr2DeY4kxKMUaKoaT VN9yAWqZLZu0UC+mgcNHipk1Uirn5UlUee7Ek++q6EggHlBOXYuUz1B/SU2LFpc5D7RREf GcY5FRFUIJkanqMBwvTiI9InFY9gGNh8Rf0h4ghhxWFEfpUrNP5e997f1Mgu0A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 304EBA7CE for ; Tue, 3 Sep 2024 02:20:27 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slHHA-0007Io-5f; Mon, 02 Sep 2024 20:20:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slHH7-0007I9-6b for guix-patches@gnu.org; Mon, 02 Sep 2024 20:20:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slHH6-0007hQ-Jk for guix-patches@gnu.org; Mon, 02 Sep 2024 20:20:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=8HpbT93fJHjcpnBC+1qc0nWljns2tw/LCMpNTGnhYFY=; b=p2A/35mLQeyoGFWqh/8N4y43Cln9jrNu1npzHMW23Hyezeh6wuGQyMTo1wYW/7FVQUUoT41XG3xYvIINUuW2+JwUB4ZcHPHvKGeKdEtbOISrzDRoMGcJLJYov491RACLSnourrfpXecPiD5g+63azOu7/mmor0JhXI6ZxWgX1vzByMSgQR8UqC6TjHiAe4hU+rp1cilpOmlRqS60M7dMD9ILEKEHPRHX7ASvGE4TfjjQ1xnTpRZTpJkYZhCu3k1csEat3+ak74fY1nc1ejLzKz3kmM3iGwBf7IN6gEHwxpZGWk0EkzHiZF2CAazg1atAIQbw56OOGZSBsHkcyk+UhQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slHI5-00048J-Qh for guix-patches@gnu.org; Mon, 02 Sep 2024 20:21:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs Resent-From: Carlo Zancanaro Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 03 Sep 2024 00:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72943 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rutherther Cc: Tobias Geerinckx-Rice , 72943@debbugs.gnu.org Received: via spool by 72943-submit@debbugs.gnu.org id=B72943.172532284215844 (code B ref 72943); Tue, 03 Sep 2024 00:21:01 +0000 Received: (at 72943) by debbugs.gnu.org; 3 Sep 2024 00:20:42 +0000 Received: from localhost ([127.0.0.1]:53203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slHHm-00047U-GF for submit@debbugs.gnu.org; Mon, 02 Sep 2024 20:20:42 -0400 Received: from voltorb.zancanaro.id.au ([45.77.50.64]:46750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slHHj-00047B-4S for 72943@debbugs.gnu.org; Mon, 02 Sep 2024 20:20:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=k1; bh=8HpbT93fJHjcpnB C+1qc0nWljns2tw/LCMpNTGnhYFY=; h=date:references:in-reply-to:subject: cc:to:from; d=zancanaro.id.au; b=WqUJUCiWqzAHmKaSV+cRAp44BShqJDANrEsm0 RYWr5J2uLAMQ+IvJTrsOQSteUTCoIfZFbOAg3LKH/jBa2sOUsuE7Ga+FZbu8bQU0SGbd3F gCVT0pKI/wTTRtPnS7wnqW95LJxzDqkC2wGWJXs5D8a5hsFLLA7QS8NcbGgBHopk= Received: by voltorb.zancanaro.id.au (OpenSMTPD) with ESMTPSA id 1c5b000e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 3 Sep 2024 00:19:23 +0000 (UTC) From: Carlo Zancanaro In-Reply-To: <87v7zeezr1.fsf@protonmail.com> (Rutherther via Guix-patches via's message of "Mon, 02 Sep 2024 17:23:22 +0000") References: <20240901191119.29870-1-rutherther@protonmail.com> <87v7zeezr1.fsf@protonmail.com> Date: Tue, 03 Sep 2024 10:19:26 +1000 Message-ID: <87bk15eghd.fsf@zancanaro.id.au> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -5.52 X-Migadu-Queue-Id: 304EBA7CE X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -5.52 X-TUID: mgq48oMH104X On Mon, Sep 02 2024, Rutherther via Guix-patches via wrote: > It seems much better to me to not use propagated-inputs whenever possible, > so I prefer your solution to this one. However, I do wonder about this: other packages that > have Requires.private do provide the libraries in these as propagated-inputs. Also > the cookbook shows to do this with such libraries. What is the correct approach here > then? Maybe every package that has Requires.private could be patched like this, possibly > somehow automatically instead of manual patches? Ah, I didn't look into it, so I didn't know that other packages in the same situation just propagate their inputs. If that's more consistent with the rest of Guix's packages then it would probably be better to do that than restoring the patch. > I am quite new here, this is my first patch. So I am not really sure how to go about this. > Will you open a new issue with your patch, and maintainers will decide patch from which > issue to use? Or is it enough it's in this issue? I wasn't planning to open a new issue. Ideally I think we would agree on which change is more appropriate, then someone with commit access would apply it. If this problem is solved elsewhere in Guix with propagated-inputs, then I think your change is a better idea than mine. This still leaves the issue of the failing tests, though. I investigated a bit and looking at [1] and [2], I believe the issue is that our version of libgd doesn't support the BICUBIC interpolation method. I'm rebuilding PHP now with those tests removed. I'll send through some patches soon. Carlo [1]: https://github.com/php/php-src/issues/11252 [2]: https://github.com/libgd/libgd/issues/847