unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: ashish.is@lostca.se
Cc: 70389@debbugs.gnu.org
Subject: [bug#70389] [PATCH v2] gnu: fossil: Update to 2.24.
Date: Sun, 15 Sep 2024 23:59:50 +0200	[thread overview]
Message-ID: <87bk0obmsp.fsf_-_@gnu.org> (raw)
In-Reply-To: <7c073e6175196f701f9104c4ac5bc20991d8b562.1722548648.git.ashish.is@lostca.se> (ashish is's message of "Thu, 1 Aug 2024 21:44:19 +0000")

Hi,

ashish.is@lostca.se skribis:

> From: Ashish SHUKLA <ashish.is@lostca.se>
>
> * gnu/packages/version-control.scm (fossil): Update to 2.24.
> [sources]: switch to a simpler tarball URL. (patches): Add patches
> from upstream to fix test failures. [inputs]: Switch to sqlite-next
> as fossil needs bleeding edge sqlite.
>
> * gnu/packages/patches/fossil-comment-utf-tests.patch: New file.
> * gnu/packages/patches/fossil-disable-tests.patch: New file.
> * gnu/packages/patches/fossil-fix-json-test.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register them.
>
> Change-Id: I0e4ffa6b5017cce345b28de953564e534282f6b4
> ---
> Hi,
>
> It seems fossil upstream has introduced a captcha on their web interface which
> is where the patches in the previous revision were fetched from. This revision
> bundles those patches.

Right, this is terrible.

> diff --git a/gnu/packages/patches/fossil-comment-utf-tests.patch b/gnu/packages/patches/fossil-comment-utf-tests.patch
> new file mode 100644
> index 0000000000..7f03362be2
> --- /dev/null
> +++ b/gnu/packages/patches/fossil-comment-utf-tests.patch
> @@ -0,0 +1,119 @@
> +Index: test/utf.test

Could you add a couple of lines at the top of each patch to (1) briefly
state what they’re about and (2) where they come from (upstream
revisions or branches they were taken from, as could be seen in the
/home/vpatch?from=X&to=Y URLs)?

Otherwise LGTM, thanks!

Ludo’.




  reply	other threads:[~2024-09-15 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-14 23:54 [bug#70389] [PATCH] gnu: fossil: update to 2.23 ashish.is--- via Guix-patches via
2024-05-21 23:59 ` [bug#70389] [PATCH v2] gnu: fossil: Update to 2.24 ashish.is--- via Guix-patches via
2024-08-01 21:44 ` ashish.is--- via Guix-patches via
2024-09-15 21:59   ` Ludovic Courtès [this message]
2024-09-16 15:48     ` [bug#70389] [PATCH v4] " Ashish SHUKLA via Guix-patches via
2024-11-19  4:53       ` [bug#70389] [PATCH v5] gnu: fossil: Update to 2.25 ashish.is--- via Guix-patches via
2024-09-16  3:29 ` [bug#70389] [PATCH v3] gnu: fossil: Update to 2.24 Ashish SHUKLA via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk0obmsp.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=70389@debbugs.gnu.org \
    --cc=ashish.is@lostca.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).