From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id yAOSJDLqAmcYlwAA62LTzQ:P1 (envelope-from ) for ; Sun, 06 Oct 2024 19:51:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id yAOSJDLqAmcYlwAA62LTzQ (envelope-from ) for ; Sun, 06 Oct 2024 21:51:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="RSvw/4FX"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=njSJB1oQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728244274; a=rsa-sha256; cv=none; b=mBtcmHnXGUCgOE2wZ1tCtD3RgSEVnvKb14ujX5cHDIW/W4lP5M7OMUvyF6BBt3kM7Yxp1d 78T3gWQp+hHGRfJGZYRkyLwsd/4PaLzv30j9TdYsz3csusk5Ft81HZ3TaW6D+z/zfpGGWr UGuHLg66R6vnNdgpUGuqmz5i/20o4MqPM20J6jv+HecdKb4YJuYAUNPTVpXB/FsUU8qfbB Uk3/BXZzRsliRptBLNdBYHVVqP+2xdoBacDywjq0YX+/Xx5l7KXdzXKdwvBQku8extF0ud yI13mqoydO8j0oTjnP4C5R5t/ml9YQwMmlRtUAvpLUdeBDaDaWrKZhcQ7ztDSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="RSvw/4FX"; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=njSJB1oQ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728244274; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=Y0+PTlBTYhmC8souGrNz3cbH5syx5wTtGDVz14EGNkA=; b=Sn9NS4+AiG2qazs1OKfaf0sJYpvqqKuVw5luHt8MnrzA+2b/vT0iBlWiXtzPCIT8LJiD4Y CB8fZrUJEGbUCOdGScfO+5O8ylrt44TSi1/14brSi+4huCwhBZTStXNZdCxWX3U7z+bFBm Tu2B7TCLYcSMKHktENxz+FsbqFsfTM9d86rjpMGwxnud7qSYY11/ECLaLYLpps3XZtxleO LZfq0tPP2j80KQKDZ7OpnkMP7bkoBqDXW6r0FJH/b/Y/8qWeNSr3sQXV9+4ZhgLcw4j8zt PY8bxAmFO92R6OMJmGXBZTfKioFjRU6A7Yta2ZB0oVwzInCwEsdSkIblDQ93IA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F37F4843F9 for ; Sun, 06 Oct 2024 21:51:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sxXHV-0003HL-Rg; Sun, 06 Oct 2024 15:51:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxXHQ-0003Fl-Va for guix-patches@gnu.org; Sun, 06 Oct 2024 15:51:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sxXHM-0001Xo-EG for guix-patches@gnu.org; Sun, 06 Oct 2024 15:51:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Y0+PTlBTYhmC8souGrNz3cbH5syx5wTtGDVz14EGNkA=; b=RSvw/4FX/4WdzchQSPNu0JnAQFk5EKMIeOjKmwt1GHgcJQuLtpCjKzPD+hCnzgYEXZba/aVvJjGSacKIUmKqg/wwFn8LOJdXrBpxJxHLePIGNHmO/GP9goEoUcNosZ6noh3N8oRSL+tT5+ViK/O1JC4zTmMsAGLd/uPuSqtGCCRBJcMkLqzuC9ej8a71BNbBvN/p+M4IC6Dywjs4QyH44p1rmZGuKuFjRj1s4oLWhwAUz9poRDB9P5EQxBQGM8i6L8yZGKhTofzJ424CERucxVNhlmXdxm0VJMh/LRsEDZx/SaQz6P5Cw1xQeEBhDJO4//gWwvLleWseZWvbya4/Lg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sxXHS-0005Hx-G7; Sun, 06 Oct 2024 15:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] [PATCH v10] gnu: Add jpm. Resent-From: Omar Bassam Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org, "Suhail Singh" Resent-Date: Sun, 06 Oct 2024 19:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Suhail Singh Cc: 72925@debbugs.gnu.org, Omar Bassam Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172824420519741 (code B ref 72925); Sun, 06 Oct 2024 19:51:02 +0000 Received: (at 72925) by debbugs.gnu.org; 6 Oct 2024 19:50:05 +0000 Received: from localhost ([127.0.0.1]:42377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxXGW-00058L-Sx for submit@debbugs.gnu.org; Sun, 06 Oct 2024 15:50:05 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:52343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxXGV-00057k-64 for 72925@debbugs.gnu.org; Sun, 06 Oct 2024 15:50:04 -0400 Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-37cdac05af9so3616789f8f.0 for <72925@debbugs.gnu.org>; Sun, 06 Oct 2024 12:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728244130; x=1728848930; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y0+PTlBTYhmC8souGrNz3cbH5syx5wTtGDVz14EGNkA=; b=njSJB1oQ+g2jB5FWfw0WryMFbcaeqF/0+M8UsNnemMTCz/jZmZ7VBu5puwV4QlzGcK QnOAtoN/xo37N9YnjAHa4BVLvicult7qs7WzFrZIdzAtCKct3jXNrF4tSzXafyowO9nK Rj4DIPy/qjT8OgxFiiOvIxdYU4/dWRYj7WYW/c4nZPTeH+xPGIrX8LB7GaYAjBeE2iF/ q1grziOX+9lg3kDB4P071YAyx6mjynOAt55JUK1lD7uh/DH0SOso6vYvDNVoZtZc+MV1 92XkN+5HkcXRO0ONVoSNvQrW+aGbgv4ex3J0Xrcwxd1UbJN1ex8kGA+HOxEaC4xWwNso GYvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728244130; x=1728848930; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y0+PTlBTYhmC8souGrNz3cbH5syx5wTtGDVz14EGNkA=; b=TRakS4J5KbiNsq4vlAPKwIIhMIDKVuvB53xi/Ix8sRCYeUNZmMQj8JQfq0SuqvhRFH U9/9QduXmpaAFD3kWXfFrjOqckmtlyss1TDvOYWjxJAt0/7CSJisuez2i/21RLY8UOmp 84UHQEmxBlJBKpBPdkgkGpNJfmeXykNFuWB2RJIgEJSw9VEaD3tCa6rQ9Hxh1E8SMp4H I4lpsMEBQsvTG5nHrno06WZEst7/VoqdnHcjm8Unw5eVtPH92cE8PIqHEzvQ7vP+GtQw Y5NJHqYsS0DvLUCu85W+njWcLUg1RNonGHdftdBY9uzz1mrlr1sc7Pam927zX3+LKcDr so/w== X-Forwarded-Encrypted: i=1; AJvYcCXuuI3If4tHsKiG95um35stYmL3v3B7FFrihjTy+xfbFQJ0+o0sGK4mOcJjxc1PRjCdHEH/Tg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxYR2qyFJRANIROs4KUuXw7qm4jtsGo0cBOhJA6/BV49W3gDIB1 6Vdj7d/282tIOZWcwCW3MSTRLI0Ygr43n88ug7FR7OS4SwI4KsCyUFYv3HZO X-Google-Smtp-Source: AGHT+IELKY2tV0hTPdtUoF4qBwbhUo5nqFkXlAEKYHgbyUHJnQr6QQcYU/nBgqkMcPieGUmNdZ6KIQ== X-Received: by 2002:a5d:58d8:0:b0:37c:cc60:2c56 with SMTP id ffacd0b85a97d-37d0e6eab2cmr8814727f8f.5.1728244129519; Sun, 06 Oct 2024 12:48:49 -0700 (PDT) Received: from omar-Latitude-5540 ([46.232.152.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a995253abfasm72432666b.185.2024.10.06.12.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2024 12:48:48 -0700 (PDT) From: Omar Bassam X-Google-Original-From: Omar Bassam In-Reply-To: <87msjh5j5f.fsf@gmail.com> (Suhail Singh's message of "Sun, 06 Oct 2024 11:46:20 -0400") References: <6e198e7dc1f64bea3a2b1498fb69e597e4d03360.1728148557.git.suhail@bayesians.ca> <87o73xgyf2.fsf@omar-Latitude-5540.mail-host-address-is-not-set> <87msjh5j5f.fsf@gmail.com> Date: Sun, 06 Oct 2024 22:48:47 +0300 Message-ID: <87bjzxgggw.fsf@omar-Latitude-5540.mail-host-address-is-not-set> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -1.90 X-Spam-Score: -1.90 X-Migadu-Queue-Id: F37F4843F9 X-Migadu-Scanner: mx12.migadu.com X-TUID: oatSGco+zeH2 Hi Suhail, Sorry, I have more questions. > Omar Bassam writes: > >>> + #:use-module (gnu packages certs) >> >> If we don't need nss-verts, do we still need this line? > > Good catch. We don't need this. Please remove in v11 when you send it. > >>> + (propagated-inputs (list janet >>> + ;; Lazily resolve the gcc-toolchain to avoid a >>> + ;; circular dependency. >>> + (module-ref (resolve-interface '(gnu packages >>> + commencement)) >>> + 'gcc-toolchain))) >> >> Since we no longer need gcc-toolchain and we are just using gcc >> directly, should we remove this module-ref expression and just add gcc >> as a propagated input? > > What we need is _some_ mechanism to ensure that when jpm invokes gcc (or > g++), the compiler is able to locate the appropriate header files. > > This should be doable without propagating any other inputs. For example > by ensuring that jpm sets appropriate environment variables (such as > $CPATH , $C_INCLUDE_PATH , $CPLUS_INCLUDE_PATH etc.) or flags when > invoking the compiler. If so, that would be the preferred approach. We > only want to propagate those inputs that are strictly necessary. > > I do know that when I had tried to remove gcc-toolchain (without doing > anything else) I encountered some errors during "jpm install -l sh" (in > a pure shell). However, I did not spend any effort in simplifying this, > and I agree that we should try to. > > I look forward to seeing what you come up with in v11 :) > I gave tried replacing gcc-toolchain with gcc and both the "jpm install" commands and the "jpm build" commands worked fine for me without any issues. I didn't need to set up any C related environemnt variables. What kind of error where you getting? >>> + ;; NOTE: Below ensures that the user provides the CA certificates they >>> + ;; desire (as opposed to bundling `nss-certs' in propagated-inputs, which >>> + ;; isn't recommended) and when they do, that they are respected. >> >> Why isn't bundling nss-certs recommended? > > Doing so would deprive the user of the choice of which CAs to trust. > I.e., if we were to bundle nss-certs we are taking an opinionated stance > that the user agrees with Mozilla project's stance on these matters. > But how will the user know that they will need to install nss-certs in the shell or that they need to setup these SSL environemnt variables? I agree of giving the user the freedom to enable or disable this but I truly believe we need to provide sane defaults. >>> + ;; FIXME: It's unclear why `search-paths', instead of >>> + ;; `native-search-paths', doesn't work. >> >> What are the difference between search-paths and >> native-search-paths. > > These are documented in the info manual. However, it's not clear to me > _why_ native-search-paths is the right thing to use in this situation. > I posted a message on guix-devel regarding this: > . > OK, please let me know when you get to the bottom of this. > The FIXME was simply an attempt to get the attention of others more > knowledgable than me. Use your discretion regd. whether to keep it or > not. > >> And were you able to run the "jpm install" command without >> nss-certs. Because, for me I was unable to do so. When I added back >> the nss-certs in propagated-inputs, it worked fine. > > That is expected behaviour. > > The way to test it, when in a pure container, would be by explicitly > ensuring that certificates of trusted CAs are included in the profile. > On way to do so would by adding nss-certs alongside jpm when invoking > the shell. > > Relying on the package to provide nss-certs isn't desirable. We simply > want to ensure that when the certs are provided that the package _is > able to use_ them. This is what the native-search-paths line > accomplishes. I still don't understand why is it an expected behaviour if jpm by default is expected to download packages mainly from github? BRs, Omar