From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id wM4lD1MXLGfKcwEAqHPOHw:P1 (envelope-from ) for ; Thu, 07 Nov 2024 01:26:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id wM4lD1MXLGfKcwEAqHPOHw (envelope-from ) for ; Thu, 07 Nov 2024 02:26:43 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=UcYUeLsL; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=pJuWfCyX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730942803; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=CTKrYNueL1ewrPhK9sTitwsldt36krERkpn6qf6K0rg=; b=LCWXJACA35MUTGM/HPDPx5J10eckv3PCR1epkb3rr17Q9JxRDCFQFGAVu3G9/cQtwoGU7L zAlGVT7ElodxI7MqwkMcK+bpO+eL8DYiT3ON6VWHGSOH0mrXjiOV6l5MM8IhJr35hhcyrw 0sDXcgMM3poQB9ckTGTIAaraEVv6olUSCuqtQxn9ir3Rav92gQTzx9g/B6WhsO/1WPYeRW lJJEBvo1f5wXpBwX2zfkK7eWkkrw9TqvjswSYKGEgUsMyNEGG6Ck7pkQClsRm2S2xrCGol sStIGcDlZSGWLWi2W/XoNL8NaWAFVh0RIAbTYzeVlY/1fQnbt8/MySMg5LFy4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=UcYUeLsL; dkim=fail ("headers rsa verify failed") header.d=ultrarare.space header.s=dkim header.b=pJuWfCyX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730942803; a=rsa-sha256; cv=none; b=caU7IJtnsPkzTnx4QP/0KMHJ96HgHUYCpU6GK8gLAHqYEEFtp0HOAYGbsdIIoDO1PTh/Nk FXZZZnfPDndglvpK+SoSLJhrf+qCVUwq0jwQnrI/FUSqkwopDA6cIu/lbgVwZewZUzKnJc j/GTpXi4qYATpevgN4XR82C1EOMYkoXoqntN1leHah7t8nnikedJuHpXEXh41Nf5fOaT5P hIYogdeLNlCoXnGv6x8a67oILlGEwr9fBNPXUrKjW5TxR1A4ZUaMAdgyrq5+r5YK5Q4//0 PqWSlCjj1upcbggfT/DwTF+P+GfOA/gVaNqgHb9JGYQiS0aJtZi4T48UiGDLLg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB72A8BD6B for ; Thu, 07 Nov 2024 02:26:42 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8rHy-0006oi-SQ; Wed, 06 Nov 2024 20:26:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8rHf-0006Ja-LM for guix-patches@gnu.org; Wed, 06 Nov 2024 20:26:06 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8rHf-0003gD-4P for guix-patches@gnu.org; Wed, 06 Nov 2024 20:26:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=CTKrYNueL1ewrPhK9sTitwsldt36krERkpn6qf6K0rg=; b=UcYUeLsLvUJe7fdCLMRY63oqgdUkPahoANgZCOAgPC7wpI+JX5bd/21pOd/Vhr2FFcRKvewbgEwPSztVJRNJRyz5K4K+m6BYCcyMWaNpTHYl/91bPj0Lq6Z/9V2VRCpcij8kgrh/ZtSKdmXYlSNngJC23J5+G7rV7b3GZ7ECW3JM9MuFmCasNU9t0JT87Hz2R6K0TLmIOXtSEF9AgbrWLj6vNelIySQvGSr+VSNC/tuuW5OLxWiC7YLQEUoXs1cTn+66ZrgkbFYqaGCdcYkHJ5aYaYtKu4ud8W9eywj4ryBmNYb+5Fqwh6XMI6t2UgEmWQEQGGePE8o4JCQfsIAFpQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t8rHe-0001em-PZ for guix-patches@gnu.org; Wed, 06 Nov 2024 20:26:02 -0500 Subject: bug#74174: [PATCH v2] gnu: Add emacs-cargo-el. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Thu, 07 Nov 2024 01:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 74174 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch easy To: Javier Olaechea Cc: 74174-done@debbugs.gnu.org, Cayetano Santos Mail-Followup-To: 74174@debbugs.gnu.org, hako@ultrarare.space, pirata@gmail.com Received: via spool by 74174-done@debbugs.gnu.org id=D74174.17309427366325 (code D ref 74174); Thu, 07 Nov 2024 01:26:02 +0000 Received: (at 74174-done) by debbugs.gnu.org; 7 Nov 2024 01:25:36 +0000 Received: from localhost ([127.0.0.1]:46606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8rHE-0001dw-9e for submit@debbugs.gnu.org; Wed, 06 Nov 2024 20:25:36 -0500 Received: from mail.boiledscript.com ([144.168.59.46]:52602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t8rHC-0001dX-9O for 74174-done@debbugs.gnu.org; Wed, 06 Nov 2024 20:25:34 -0500 Date: Thu, 07 Nov 2024 09:25:10 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1730942728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CTKrYNueL1ewrPhK9sTitwsldt36krERkpn6qf6K0rg=; b=pJuWfCyX4Ke92emnxtP4T06o1VN4T1kpikSI09JhUQa+oT1PT8OnZ1KcSXzTTJyTmzC1Hp kdNefIHTktZHOMtOy4nlCq8HUgpp6CXekoGsUOpXpTLkYS+hHW0Q0zKslF5EGwz7+yKe6r Q28+XMwUGm55W7kLZz5JIcuFzZFCGhAnx7gdGhYkIpATzrlikmBY6k6B7Zqi4uDYBxyxv0 7hMWsEdCJLQ+8hBzAQ9IndfsmgkVIvbcAIPbb6nGl5fpvRnrix58k6R2jFAg+ISIja+ToK v+NQiqA+cK3CyJwb6506cFEWaxOG/aFLatX4kV/VFWUM6FFYWO56kBy2ZohfkA== Message-ID: <87bjyrg7ih.wl-hako@ultrarare.space> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP X-Spamd-Bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Hilton Chain X-ACL-Warn: , Hilton Chain via Guix-patches From: Hilton Chain via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 0.06 X-Spam-Score: 0.06 X-Migadu-Queue-Id: CB72A8BD6B X-TUID: GTPEYYiUdioa Hi Javier, On Tue, 05 Nov 2024 12:54:49 +0800, Javier Olaechea wrote: > > [1 ] > [1.1 ] > [1.2 ] > Guix QA review form submission: > > > - sentences in description should be followed by two spaces > > Updated the description accordingly > > > - check propagated-inputs, emacs-rust-mode instead of > > emacs-markdown-mode ? > > No, the package doesn't depend on rust-mode at all. It shells out the cargo and rustc instead. The require > calls in the elisp files are We generally patch these references to paths within /gnu/store. > (require 'xref) > (require 'compile) > (require 'button) > (require 'markdown-mode) > (require 'tramp) > > Of those, only emacs-markdown-mode is not a built-in package. Although we could add xref and tramp as inputs. > They are also distributed as separate packages in GNU Elpa. This means they have a separate release cadence > from emacs. What do you think? > > > - first revision should be 0 instead of 1 ? > > Thanks, it is true 'hackers count from 0'. ^_^. Updated. There's no strict requirement on revisions :) Just make sure (version + revision) is increasing when updating package source. > Cheers > -- > "I object to doing things that computers can do." ― Olin Shivers > [2 v2-0001-gnu-Add-emacs-cargo-el.patch ] > From 95bb683ce62fd38c9bbbc4efa4f3499d0cc4f647 Mon Sep 17 00:00:00 2001 > Message-ID: <95bb683ce62fd38c9bbbc4efa4f3499d0cc4f647.1730781951.git.pirata@gmail.com> > From: Javier Olaechea > Date: Sat, 2 Nov 2024 00:36:57 -0500 > Subject: [PATCH v2] gnu: Add emacs-cargo-el Don't forget to end the subject with ‘.’ > * gnu/packages/emacs-xyz.scm (emacs-cargo-el): New variable. > > Change-Id: I73a99eeb818fb1c7ab87cc15c5953beba818cb94 > --- > gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index 59c804066a..fc8a5839b4 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -29667,6 +29667,29 @@ (define-public emacs-rustic > (license (list license:expat > license:asl2.0)))) > > +(define-public emacs-cargo-el > + (let ((commit "7f8466063381eed05d4e222ce822b1dd44e3bf17") > + (revision "0")) > + (package > + (name "emacs-cargo-el") > + (version "0.4.0") The version 0.4.0 doesn't match upstream commit 7f8466063381, so we shouldn't use it here. Please see package guidelines on version numbers[1] for details. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/kwrooijen/cargo.el") > + (commit commit))) Don't forget to add a file name to this origin, you can use ‘guix lint’ to identify such issue. > + (sha256 > + (base32 "1hvxdmyppvx04jyn07dnynlgbwyasv22k8dd4qa68mrj8i9mz484")))) > + (build-system emacs-build-system) > + (propagated-inputs (list emacs-markdown-mode)) > + (home-page "https://github.com/kwrooijen/cargo.el") > + (synopsis "Emacs Minor Mode for Cargo, Rust's Package Manager") Uppercase only when it's meaningful. > + (description > + "Cargo mode for Emacs. This package gives you a set of key combinations to > +perform Cargo tasks within your Rust projects.") Use full sentences for description, "Cargo mode for Emacs" should be reworded. Guidelines for synopses and descriptions are available in [2]. > + (license license:gpl3+)))) > + > (define-public emacs-ztree > ;; Upstream provides no tag, but the commit below matches latest release. > (let ((commit "c9ad9136d52ca5a81475693864e255d29448f43f")) > > base-commit: 33665c52c4670bc3b4d337c89ac9cc6c4c69b26f > -- > 2.46.0 I have adjusted your patch based on above comments and applied it as 673b924ac1e30a5d498e28859af365cf2bb4a508, thanks! Also thanks for Cayetano's previous review! --- [1]: https://guix.gnu.org/manual/devel/en/html_node/Version-Numbers.html [2]: https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html