unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Zheng Junjie <zhengjunjie@iscas.ac.cn>
Cc: 74645@debbugs.gnu.org
Subject: [bug#74645] [PATCH] gnu: pkgconf: Update to 2.3.0.
Date: Sun, 08 Dec 2024 15:06:48 +0900	[thread overview]
Message-ID: <87bjxmk8sn.fsf@gmail.com> (raw)
In-Reply-To: <f18a209a83cc89eb42da082c555279eed97910c4.1733128982.git.zhengjunjie@iscas.ac.cn> (Zheng Junjie's message of "Mon, 2 Dec 2024 16:43:02 +0800")

Hi,

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:

> * gnu/packages/pkg-config.scm (pkgconf): Update to 2.3.0.
>
> Change-Id: Ifaed690166dd3461161594a94146638eb872bb20
> ---
>  gnu/packages/pkg-config.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/pkg-config.scm b/gnu/packages/pkg-config.scm
> index d5655bd893b..44ab52b32e0 100644
> --- a/gnu/packages/pkg-config.scm
> +++ b/gnu/packages/pkg-config.scm
> @@ -3,7 +3,7 @@
>  ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
>  ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
>  ;;; Copyright © 2022, 2024 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> -;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> +;;; Copyright © 2023, 2024 Zheng Junjie <873216071@qq.com>

Nitpick, but changes of < 15 lines of code are not considered
copyrightable, so I wouldn't update the copyright line.

[...]

> @@ -179,14 +179,14 @@ (define-public pkg-config-for-build
>  (define-public pkgconf
>    (package
>      (name "pkgconf")
> -    (version "2.1.0")
> +    (version "2.3.0")
>      (source (origin
>                (method url-fetch)
>                (uri (string-append  "https://distfiles.dereferenced.org/"
>                                     name "/" name "-" version ".tar.xz"))
>                (sha256
>                 (base32
> -                "0qbpczwrrsq2981mdv3iil26vq9ac8v1sfi9233jpiaixrhmhv96"))))
> +                "12zaw363yk90i9ib04sz5f4j917hilm0l2liq7kiadnha6n8141s"))))
>      (build-system gnu-build-system)
>      (arguments
>       (list #:phases #~(modify-phases %standard-phases

The rest LGTM!

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

-- 
Thanks,
Maxim




  reply	other threads:[~2024-12-08  6:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02  8:43 [bug#74645] [PATCH] gnu: pkgconf: Update to 2.3.0 Zheng Junjie
2024-12-08  6:06 ` Maxim Cournoyer [this message]
2024-12-09  6:35   ` bug#74645: " Zheng Junjie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjxmk8sn.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=74645@debbugs.gnu.org \
    --cc=zhengjunjie@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).