unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Christoph Buck <dev@icepic.de>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
	paren@disroot.org, Tobias Geerinckx-Rice <me@tobias.gr>,
	jgart <jgart@dismail.de>, Mathieu Othacehe <othacehe@gnu.org>,
	Christopher Baines <guix@cbaines.net>,
	74830-done@debbugs.gnu.org
Subject: bug#74830: [PATCH] gnu: libcbor: Fix cross-compiling to 32-bit architecture
Date: Sun, 15 Dec 2024 23:54:29 +0100	[thread overview]
Message-ID: <87bjxch80q.fsf@gnu.org> (raw)
In-Reply-To: <62a9e8b6613b09d0a260007aa2c79ad05cf774df.1734012275.git.dev@icepic.de> (Christoph Buck's message of "Thu, 12 Dec 2024 14:04:35 +0000")

Christoph Buck <dev@icepic.de> skribis:

> * gnu/packages/compression.scm (libcbor)[arguments]: Disable examples because
> they don't build during cross-compilation. The callback definition
> `find_string` in examples/streaming_parser.c uses `size_t` as type for
> argument `len` which is 4 bytes on a 32bit platform. However, the callback
> handler of type `cbor_callbacks.string` to which `find_string` is assigned
> expects an `uint64_t`. Since the examples are not required this patch will
> disable them from the build.
>
> Change-Id: I596a62a9d0ab936179c8344e91ecc2cb0419316f

Applied, thanks.  I took the liberty to add some of the explanation as a
comment, to make it easier to find.

Ludo’.




      reply	other threads:[~2024-12-15 22:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 14:04 [bug#74830] [PATCH] gnu: libcbor: Fix cross-compiling to 32-bit architecture Christoph Buck
2024-12-15 22:54 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjxch80q.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=74830-done@debbugs.gnu.org \
    --cc=dev@icepic.de \
    --cc=guix@cbaines.net \
    --cc=jgart@dismail.de \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    --cc=paren@disroot.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).