From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YBY6GHzHbWf1aQEA62LTzQ:P1 (envelope-from ) for ; Thu, 26 Dec 2024 21:15:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id YBY6GHzHbWf1aQEA62LTzQ (envelope-from ) for ; Thu, 26 Dec 2024 22:15:40 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=rZZGKVyr; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Gkwx07nj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735247740; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=0Uku5r0iTpZVpLq+ajrd5nfGjnnVmB8b37coxb9n5oo=; b=GLZleDfyfStKxbYwozJMguZhNieUD2osZNrwK67eVP1srNmr1fgcqvUJL2lN+PK3I9XEb/ UUZ5qZdy1LgXsrY+3icUadnZOd1hgK+pQ+8SFqDyiCyCBk+0JfkW9xDZRsHnM6PjeGWc+q NOpL7sXmhdh5wcf/4FBf/dGSsMznFa7bbiCtPCOanL96xvs6DY0hxpzWmVCDJyhCMCL+U9 LlCnmyvnSfvEW9GsZCRd2v6RvXFTjWZTk8s5GBmds9J7kVms7Rqwz5c+U5PqotIVn/9iiw 8JklIXbfBzYHzGc2396bKULlJsOuz571hfOQ/jIrVoD9bEGlAYX4VQxBjLsa8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=rZZGKVyr; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Gkwx07nj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735247740; a=rsa-sha256; cv=none; b=V2PwD58sbhH33BirgxtfSJm8hme2eQKJXrz5BXnGnymSTs05P8YYtZ1x/MU52n/jv5LO49 3z24fW0/p/gPYFkSkv9SVhGANNmxXlmyS/r9X1dDY1eLcjhZlY/Z8MTRkwAr20ta38/r8A lOkOCoUbQIzTEO4lni1iY59lz/DiIYI0Bif4xGjWZumWML9jRALl7F8i300LLca5e4J1pA 4Q9m0mwI1JYGPkUZnPfSMs8biDZKR/3MXCRzVlGp1TM3iQSqCs8Er4uShZShtf0mrMD/BQ D8HWe+PosA1HNKJzi5QFtwkgFA9rjYuEtkg7DqVOb9Ws4oOyryYCP+yRi3f/RQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6FFBB1F180 for ; Thu, 26 Dec 2024 22:15:39 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQvCC-00036l-VQ; Thu, 26 Dec 2024 16:15:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQvCB-000362-BP for guix-patches@gnu.org; Thu, 26 Dec 2024 16:15:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tQvCB-0002T7-1Y for guix-patches@gnu.org; Thu, 26 Dec 2024 16:15:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=0Uku5r0iTpZVpLq+ajrd5nfGjnnVmB8b37coxb9n5oo=; b=rZZGKVyrsECDm1VM0kzLV08QXVd6C6MVX+ZNEa7nb3NjzB9wcOPLltN27talnWoKTbf+Xt/girxEHGtNsyHbI99g014OR4a9c3lJKFzn6LPKYKl0+8Ca99PfPm/yV738XGow/d4iw8ZAr8+PRHZ/pAIb0HiIQjJQ2zv0ElgbOSWf6ZD2xuWjffbTFui74GWpYDlHDjB0mrt+0mdBYDALkO3qg4LYSCf68qZmKewJqFm6B1AS8d21S5z5ZIGXuZ1V3i5JAihVD6hoLJwfQEdvPi1ZdnSwZ9TzDZsZd6HINR4nicx9JgTerG6djdyU60gYIGZoMu7m/HW6eqCbcnlJew==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tQvCA-0002MQ-Ss for guix-patches@gnu.org; Thu, 26 Dec 2024 16:15:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74481] [PATCH v2] import: go: Warn instead of error out when Git fails. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 Dec 2024 21:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74481 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: 74481@debbugs.gnu.org, Katherine Cox-Buday , Sharlatan Hellseher Received: via spool by 74481-submit@debbugs.gnu.org id=B74481.17352476919022 (code B ref 74481); Thu, 26 Dec 2024 21:15:02 +0000 Received: (at 74481) by debbugs.gnu.org; 26 Dec 2024 21:14:51 +0000 Received: from localhost ([127.0.0.1]:42448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQvBy-0002LP-W1 for submit@debbugs.gnu.org; Thu, 26 Dec 2024 16:14:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tQvBw-0002LA-Vz for 74481@debbugs.gnu.org; Thu, 26 Dec 2024 16:14:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQvBr-0002MJ-PM; Thu, 26 Dec 2024 16:14:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=0Uku5r0iTpZVpLq+ajrd5nfGjnnVmB8b37coxb9n5oo=; b=Gkwx07njLRlEt+yfnVKo 4Zg4I8zBnRwPF1a39TM2KcxCQunSz3s3PeNa/KJwUfnCQhSwubk1U5vewYbqrncfJoLqiWv8/93IZ OoMhGjQAGI6wXsekrtfadxkTVzUBhUl+JhGuHk5ramUWEfFuBlVMRYHIImmLXJ5+v7WQEcYBefzjy UH2zM/11JPgNRYV+6QVlSlzzkUTWMv1EJLqT3o2YGxOu+slfjveh/jlzyG3E+L2VB2QNFD9nnO86q 5Ps8Rj9RDObjVghrMI+pJ454oe7ujoYgHQJmtTX99vF+6vUjtR5mg6VOw/+tKqbdDi7HjMop9ZpfZ 4Mxj3fjBfcYAnA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <494fef0566a7105bf4ae04f5efeae742561f3abb.1734457415.git.zimon.toutoune@gmail.com> (Simon Tournier's message of "Tue, 17 Dec 2024 18:45:02 +0100") References: <494fef0566a7105bf4ae04f5efeae742561f3abb.1734457415.git.zimon.toutoune@gmail.com> Date: Thu, 26 Dec 2024 22:14:41 +0100 Message-ID: <87bjwy170e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.21 X-Spam-Score: -7.21 X-Migadu-Queue-Id: 6FFBB1F180 X-Migadu-Scanner: mx10.migadu.com X-TUID: oK0hKKd0kQUy Simon Tournier skribis: > * guix/import/go.scm (git-checkout-hash): Return some hash although updat= ing > the cache fails. > > Change-Id: I87e7701023a5f76f5d1494827473616e6a1275aa [...] > + (catch 'git-error > + (lambda () > + (update-cached-checkout url > + #:ref > + `(tag-or-commit . ,referen= ce))) > + (lambda (key err) > + (warning (G_ "update-cached-checkout: ~s ~s~%") ke= y err) Rather something like: (warning (G_ "failed to check out ~s from Git repository at '~a': ~a~%") reference url (git-error-message err)) Apart from that LGTM! Thanks, Ludo=E2=80=99.