unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 74481@debbugs.gnu.org,
	Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
	Sharlatan Hellseher <sharlatanus@gmail.com>
Subject: [bug#74481] [PATCH v2] import: go: Warn instead of error out when Git fails.
Date: Thu, 26 Dec 2024 22:14:41 +0100	[thread overview]
Message-ID: <87bjwy170e.fsf@gnu.org> (raw)
In-Reply-To: <494fef0566a7105bf4ae04f5efeae742561f3abb.1734457415.git.zimon.toutoune@gmail.com> (Simon Tournier's message of "Tue, 17 Dec 2024 18:45:02 +0100")

Simon Tournier <zimon.toutoune@gmail.com> skribis:

> * guix/import/go.scm (git-checkout-hash): Return some hash although updating
> the cache fails.
>
> Change-Id: I87e7701023a5f76f5d1494827473616e6a1275aa

[...]

> +                  (catch 'git-error
> +                    (lambda ()
> +                      (update-cached-checkout url
> +                                              #:ref
> +                                              `(tag-or-commit . ,reference)))
> +                    (lambda (key err)
> +                      (warning (G_ "update-cached-checkout: ~s ~s~%") key err)

Rather something like:

  (warning (G_ "failed to check out ~s from Git repository at '~a': ~a~%")
           reference url (git-error-message err))

Apart from that LGTM!

Thanks,
Ludo’.




  reply	other threads:[~2024-12-26 21:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22 19:05 [bug#74481] [PATCH 0/2] Handle corner cases of 'guix import go' Simon Tournier
2024-11-22 19:09 ` [bug#74481] [PATCH 1/2] git: Catch Git errors when updating cached checkout Simon Tournier
2024-12-12 11:34   ` Ludovic Courtès
2024-12-12 12:04     ` Simon Tournier
2024-12-17 10:55       ` Ludovic Courtès
2024-12-17 18:06         ` Simon Tournier
2024-12-26 21:17           ` Ludovic Courtès
2024-11-22 19:09 ` [bug#74481] [PATCH 2/2] import: go: Warn instead of error out when reference is missing Simon Tournier
2024-12-10 14:09 ` [bug#74481] [PATCH 0/2] Handle corner cases of 'guix import go' Simon Tournier
2024-12-10 18:40   ` Sharlatan Hellseher
2024-12-17 17:45 ` [bug#74481] [PATCH v2] import: go: Warn instead of error out when Git fails Simon Tournier
2024-12-26 21:14   ` Ludovic Courtès [this message]
2024-12-18 20:18 ` [bug#74481] [PATCH 0/2] Handle corner cases of 'guix import go' Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjwy170e.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=74481@debbugs.gnu.org \
    --cc=cox.katherine.e+guix@gmail.com \
    --cc=sharlatanus@gmail.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).