[bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter.

unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed

* [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter.
       [not found] <87h66uvj1w.fsf@163.com>
@ 2024-12-25  3:04 ` tumashu
  2024-12-30  8:56   ` Zheng Junjie
  2024-12-30  1:46 ` [bug#75044] Please review this patch Feng Shu
  2024-12-30 13:46 ` [bug#75044] [PATCH v3] gnu: Add lightdm-mini-greeter tumashu
  2 siblings, 1 reply; 6+ messages in thread
From: tumashu @ 2024-12-25  3:04 UTC (permalink / raw)
  To: 75044; +Cc: Feng Shu, Feng Shu

From: Feng Shu <tumashu@163.com>

* gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.

Change-Id: I558add1665d79429e2562c2139777002b7a70466
---
 gnu/packages/display-managers.scm | 46 +++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index df5fc0a857..b70f8101e6 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -543,6 +543,52 @@ (define-public lightdm-gtk-greeter
 GTK+, lets you select a desktop session and log in to it.")
     (license license:gpl3+)))
 
+(define-public lightdm-mini-greeter
+  (package
+    (name "lightdm-mini-greeter")
+    (version "0.5.1-ead793")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/prikhi/lightdm-mini-greeter")
+                    (commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
+    (build-system glib-or-gtk-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'customize-default-config-path
+            (lambda _
+              (substitute* "Makefile.am"
+                ;; Have the default config directory sourced from
+                ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
+                ;; lightdm service writes it.
+                (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
+                 "/etc/lightdm/lightdm-mini-greeter.conf"))))
+          (add-after 'install 'fix-.desktop-file
+            (lambda* (#:key outputs #:allow-other-keys)
+              (substitute* (search-input-file
+                            outputs
+                            "share/xgreeters/lightdm-mini-greeter.desktop")
+                (("Exec=lightdm-mini-greeter")
+                 (string-append "Exec="
+                                (search-input-file
+                                 outputs "bin/lightdm-mini-greeter")))))))))
+    (native-inputs
+     (list autoconf automake pkg-config))
+    (inputs
+     (list gtk+ lightdm))
+    (synopsis "Mini Greeter for LightDM")
+    (home-page "https://github.com/prikhi/lightdm-mini-greeter")
+    (description "This package provide a minimal but highly configurable single-user GTK3
+greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
+LightDM GTK3 Greeter.")
+    (license license:gpl3)))
+
 (define-public slim
   (package
     (name "slim")
-- 
2.45.2





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter.
  2024-12-25  3:04 ` [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter tumashu
@ 2024-12-30  8:56   ` Zheng Junjie
  2024-12-30 13:48     ` Feng Shu
  0 siblings, 1 reply; 6+ messages in thread
From: Zheng Junjie @ 2024-12-30  8:56 UTC (permalink / raw)
  To: tumashu; +Cc: 75044

[-- Attachment #1: Type: text/plain, Size: 3628 bytes --]

tumashu@163.com writes:

> From: Feng Shu <tumashu@163.com>
>
> * gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.
>
> Change-Id: I558add1665d79429e2562c2139777002b7a70466
> ---
>  gnu/packages/display-managers.scm | 46 +++++++++++++++++++++++++++++++
>  1 file changed, 46 insertions(+)
>
> diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
> index df5fc0a857..b70f8101e6 100644
> --- a/gnu/packages/display-managers.scm
> +++ b/gnu/packages/display-managers.scm
> @@ -543,6 +543,52 @@ (define-public lightdm-gtk-greeter
>  GTK+, lets you select a desktop session and log in to it.")
>      (license license:gpl3+)))
>  
> +(define-public lightdm-mini-greeter
> +  (package
> +    (name "lightdm-mini-greeter")
> +    (version "0.5.1-ead793")

please use git-version, likes: 

(define-public lightdm-mini-greeter
  (let ((commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")
        (revision "0"))
   (package
      ...
      (source
         (origin
           (method git-fetch)
           (uri (git-reference
                   (url "https://github.com/prikhi/lightdm-mini-greeter")
                   (commit commit)))
           (file-name (git-file-name name version))
           (sha256
            (base32
             "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
      ...)))
   
and add comment for why use commit, not git tag.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/prikhi/lightdm-mini-greeter")
> +                    (commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
> +    (build-system glib-or-gtk-build-system)
> +    (arguments
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'customize-default-config-path
> +            (lambda _
> +              (substitute* "Makefile.am"
> +                ;; Have the default config directory sourced from
> +                ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
> +                ;; lightdm service writes it.
> +                (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
> +                 "/etc/lightdm/lightdm-mini-greeter.conf"))))
> +          (add-after 'install 'fix-.desktop-file
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (substitute* (search-input-file
> +                            outputs
> +                            "share/xgreeters/lightdm-mini-greeter.desktop")
> +                (("Exec=lightdm-mini-greeter")
> +                 (string-append "Exec="
> +                                (search-input-file
> +                                 outputs "bin/lightdm-mini-greeter")))))))))
> +    (native-inputs
> +     (list autoconf automake pkg-config))
> +    (inputs
> +     (list gtk+ lightdm))
> +    (synopsis "Mini Greeter for LightDM")
> +    (home-page "https://github.com/prikhi/lightdm-mini-greeter")
> +    (description "This package provide a minimal but highly configurable single-user GTK3
> +greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
> +LightDM GTK3 Greeter.")
> +    (license license:gpl3)))
> +
>  (define-public slim
>    (package
>      (name "slim")

I didn't compile, test, everything else looks good.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter.
  2024-12-30  8:56   ` Zheng Junjie
@ 2024-12-30 13:48     ` Feng Shu
  0 siblings, 0 replies; 6+ messages in thread
From: Feng Shu @ 2024-12-30 13:48 UTC (permalink / raw)
  To: Zheng Junjie; +Cc: 75044

Zheng Junjie <zhengjunjie@iscas.ac.cn> writes:


> please use git-version, likes: 
> and add comment for why use commit, not git tag.

Updated.





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#75044] Please review this patch.
       [not found] <87h66uvj1w.fsf@163.com>
  2024-12-25  3:04 ` [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter tumashu
@ 2024-12-30  1:46 ` Feng Shu
  2024-12-30 13:46 ` [bug#75044] [PATCH v3] gnu: Add lightdm-mini-greeter tumashu
  2 siblings, 0 replies; 6+ messages in thread
From: Feng Shu @ 2024-12-30  1:46 UTC (permalink / raw)
  To: 75043, 75044, 75048


Please review this patch, thanks.

-- 





^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#75044] [PATCH v3] gnu: Add lightdm-mini-greeter.
       [not found] <87h66uvj1w.fsf@163.com>
  2024-12-25  3:04 ` [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter tumashu
  2024-12-30  1:46 ` [bug#75044] Please review this patch Feng Shu
@ 2024-12-30 13:46 ` tumashu
  2025-01-02 13:03   ` bug#75044: " Zheng Junjie
  2 siblings, 1 reply; 6+ messages in thread
From: tumashu @ 2024-12-30 13:46 UTC (permalink / raw)
  To: 75044; +Cc: Feng Shu, Feng Shu, tumashu, Zheng Junjie

From: Feng Shu <tumashu@163.com>

* gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.

Change-Id: I558add1665d79429e2562c2139777002b7a70466
---
 gnu/packages/display-managers.scm | 49 +++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
index df5fc0a857..61be09adac 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -543,6 +543,55 @@ (define-public lightdm-gtk-greeter
 GTK+, lets you select a desktop session and log in to it.")
     (license license:gpl3+)))
 
+(define-public lightdm-mini-greeter
+  (let ((commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")
+        (revision "0"))
+    (package
+      (name "lightdm-mini-greeter")
+      ;; Version 0.5.1 release three years ago, so we use a recent commit.
+      (version (git-version "0.5.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/prikhi/lightdm-mini-greeter")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
+      (build-system glib-or-gtk-build-system)
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'customize-default-config-path
+              (lambda _
+                (substitute* "Makefile.am"
+                  ;; Have the default config directory sourced from
+                  ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
+                  ;; lightdm service writes it.
+                  (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
+                   "/etc/lightdm/lightdm-mini-greeter.conf"))))
+            (add-after 'install 'fix-.desktop-file
+              (lambda* (#:key outputs #:allow-other-keys)
+                (substitute* (search-input-file
+                              outputs
+                              "share/xgreeters/lightdm-mini-greeter.desktop")
+                  (("Exec=lightdm-mini-greeter")
+                   (string-append "Exec="
+                                  (search-input-file
+                                   outputs "bin/lightdm-mini-greeter")))))))))
+      (native-inputs
+       (list autoconf automake pkg-config))
+      (inputs
+       (list gtk+ lightdm))
+      (synopsis "Mini Greeter for LightDM")
+      (home-page "https://github.com/prikhi/lightdm-mini-greeter")
+      (description "This package provide a minimal but highly configurable single-user GTK3
+greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
+LightDM GTK3 Greeter.")
+      (license license:gpl3))))
+
 (define-public slim
   (package
     (name "slim")
-- 
2.47.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#75044: [PATCH v3] gnu: Add lightdm-mini-greeter.
  2024-12-30 13:46 ` [bug#75044] [PATCH v3] gnu: Add lightdm-mini-greeter tumashu
@ 2025-01-02 13:03   ` Zheng Junjie
  0 siblings, 0 replies; 6+ messages in thread
From: Zheng Junjie @ 2025-01-02 13:03 UTC (permalink / raw)
  To: tumashu; +Cc: 75044-done

[-- Attachment #1: Type: text/plain, Size: 3239 bytes --]

tumashu@163.com writes:

> From: Feng Shu <tumashu@163.com>
>
> * gnu/packages/display-managers.scm (lightdm-mini-greeter): New variable.
>
> Change-Id: I558add1665d79429e2562c2139777002b7a70466
> ---
>  gnu/packages/display-managers.scm | 49 +++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
>
> diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm
> index df5fc0a857..61be09adac 100644
> --- a/gnu/packages/display-managers.scm
> +++ b/gnu/packages/display-managers.scm
> @@ -543,6 +543,55 @@ (define-public lightdm-gtk-greeter
>  GTK+, lets you select a desktop session and log in to it.")
>      (license license:gpl3+)))
>  
> +(define-public lightdm-mini-greeter
> +  (let ((commit "ead7936993b4e9e067d73fa49dec7edfb46c73a8")
> +        (revision "0"))
> +    (package
> +      (name "lightdm-mini-greeter")
> +      ;; Version 0.5.1 release three years ago, so we use a recent commit.

Change to use an absolute date

> +      (version (git-version "0.5.1" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/prikhi/lightdm-mini-greeter")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "17iy1jkllmi2xc95csb18wcfvbk44gyva2in2k5f29fy362ppz25"))))
> +      (build-system glib-or-gtk-build-system)
> +      (arguments
> +       (list
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'customize-default-config-path
> +              (lambda _
> +                (substitute* "Makefile.am"
> +                  ;; Have the default config directory sourced from
> +                  ;; /etc/lightdm/lightdm-mini-greeter.conf, which is where the
> +                  ;; lightdm service writes it.
> +                  (("\\$\\(sysconfdir)/lightdm/lightdm-mini-greeter.conf")
> +                   "/etc/lightdm/lightdm-mini-greeter.conf"))))
> +            (add-after 'install 'fix-.desktop-file
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (substitute* (search-input-file
> +                              outputs
> +                              "share/xgreeters/lightdm-mini-greeter.desktop")
> +                  (("Exec=lightdm-mini-greeter")
> +                   (string-append "Exec="
> +                                  (search-input-file
> +                                   outputs "bin/lightdm-mini-greeter")))))))))
> +      (native-inputs
> +       (list autoconf automake pkg-config))
> +      (inputs
> +       (list gtk+ lightdm))
> +      (synopsis "Mini Greeter for LightDM")
> +      (home-page "https://github.com/prikhi/lightdm-mini-greeter")
> +      (description "This package provide a minimal but highly configurable single-user GTK3
> +greeter for LightDM, this greeter is inspired by the SLiM Display Manager and
> +LightDM GTK3 Greeter.")
> +      (license license:gpl3))))
> +
>  (define-public slim
>    (package
>      (name "slim")
pushed, closing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-01-02 13:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87h66uvj1w.fsf@163.com>
2024-12-25  3:04 ` [bug#75044] [PATCH v2] gnu: Add lightdm-mini-greeter tumashu
2024-12-30  8:56   ` Zheng Junjie
2024-12-30 13:48     ` Feng Shu
2024-12-30  1:46 ` [bug#75044] Please review this patch Feng Shu
2024-12-30 13:46 ` [bug#75044] [PATCH v3] gnu: Add lightdm-mini-greeter tumashu
2025-01-02 13:03   ` bug#75044: " Zheng Junjie

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).