From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxW5F-0003n9-V9
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:58:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxW5C-00015H-3A
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:58:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42414)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cxW5B-000159-VP
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxW5B-0001D7-OF
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:58:01 -0400
Subject: bug#26369: [PATCH] import cran: Fetch DESCRIPTION files from Github
	mirror.
Resent-Message-ID: <handler.26369.B26369.14918182694631@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170405133703.4302-1-rekado@elephly.net>
Date: Mon, 10 Apr 2017 11:57:35 +0200
In-Reply-To: <20170405133703.4302-1-rekado@elephly.net> (Ricardo Wurmus's
	message of "Wed, 5 Apr 2017 15:37:03 +0200")
Message-ID: <87a87oega8.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 26369@debbugs.gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * guix/import/cran.scm (%bioconductor-svn-url): Remove variable.
> (bioconductor-mirror-url): New procedure.
> (fetch-description): Take a REPOSITORY symbol instead of a BASE-URL strin=
g.
> (cran->guix-package): Pass REPOSITORY symbol to "fetch-description".
> (latest-cran-release, latest-bioconductor-release): Adjust accordingly.
> (bioconductor-package?): Update comment about SVN.

LGTM.

Out of curiosity, what=E2=80=99s the rationale for using the GitHub mirror
instead of the SVN repo?

Thanks,
Ludo=E2=80=99.