From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40442)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cz2hk-0004MT-0o
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:00:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cz2hf-0001J2-FF
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:00:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49127)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cz2hf-0001Io-CL
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:00:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cz2hf-0003Pc-3T
	for guix-patches@gnu.org; Fri, 14 Apr 2017 11:00:03 -0400
Subject: bug#26462: [PATCH 1/2] gnu: icu4c: Fix crashes in programs using
	system ICU.
Resent-Message-ID: <handler.26462.B26462.149218199013065@debbugs.gnu.org>
References: <878tn5vr4b.fsf@lassieur.org>
	<20170412105325.8099-1-clement@lassieur.org> <87d1chete8.fsf@gnu.org>
	<87bmrzm42e.fsf@lassieur.org>
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
In-reply-to: <87bmrzm42e.fsf@lassieur.org>
Date: Fri, 14 Apr 2017 16:59:45 +0200
Message-ID: <87a87jm3vi.fsf@lassieur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 26462@debbugs.gnu.org

Clément Lassieur <clement@lassieur.org> writes:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Clément Lassieur <clement@lassieur.org> skribis:
>>
>>> * gnu/packages/patches/icu4c-reset-keyword-list-iterator.patch: New file.
>>> * gnu/local.mk (dist_patch_DATA): Add it.
>>> * gnu/packages/icu4c.scm (icu4c)[source]: Use it.
>>
>> [...]
>>
>>> +++ b/gnu/packages/patches/icu4c-reset-keyword-list-iterator.patch
>>> @@ -0,0 +1,128 @@
>>> +Copied from upstream: http://bugs.icu-project.org/trac/changeset/39484/.
>>> +
>>> +Paths and line endings have been adapted.
>>
>> Woow, good catch!
>>
>> 1,700 packages depend on icu4c so the update would have to go to
>> ‘core-updates’, but that won’t be merged until several weeks.
>>
>> For ‘master’, in the meantime, I see two solutions:
>>
>>   1. If the bug only affects specific applications, we could add an
>>      icu4c variant and use that only where needed (icecat, 0ad, etc.).
>>
>>   2. If the bug manifests itself pervasively we could graft it in
>>      ‘master’ (I guess it’s ABI-compatible, right?).
>>
>> Thoughts?
>
> I prefer the second solution, in case the bug appears in other
> applications as well, and I think it is ABI-compatible.  I just sent the
> patch for the graft in master.  I'll do the patch for core-updates
> later, when master is merged into it.

But I might be wrong :)  If you think the first solution is better,
don't hesitate to tell me, I'll do another patch.