unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Alex Kost <alezost@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26802@debbugs.gnu.org
Subject: bug#26802: Single source file emacs packages get a ".el.el" extension
Date: Tue, 16 May 2017 20:29:17 +0300	[thread overview]
Message-ID: <87a86czp5e.fsf@gmail.com> (raw)
In-Reply-To: <eac56466.AEQAKZSU7kQAAAAAAAAAAAO9aM4AAAACwQwAAAAAAAW9WABZGa0d@mailjet.com> (Arun Isaac's message of "Mon, 15 May 2017 18:58:29 +0530")

Arun Isaac (2017-05-15 18:58 +0530) wrote:

>> I'm not sure, I think:
>>
>> - it's too much for all the sources, as the upstream source may not
>> contain a version in the file name at all.  Do we really want to raise a
>> warning in this case?
>
>> - and it's not enough for ".el" sources, I mean "something-version.el"
>> is not enough, as the file name must exactly be "name-version.el" (as it
>> is with ELPA single-filed sources), so the emacs-build-system will
>> output "name.el" file which will correspond to 'name' feature provided
>> by this file.
>
> You have a point, but...
>
> If all packages cannot be expected to have "name-version", then it is
> unreasonable and arbitrary to only expect single source file emacs
> packages to have a filename of this format. Instead, the emacs build
> system should be made more robust so that it can tolerate a souce file
> name like "web-mode.el" and still produce the correct installation path.

Yeah, it would definitely be good to make emacs-build-system more robust.

After thinking more, I came to the conclusion that expanding the linter
to check any source for "name-version" is a good idea (if this is what
you suggest, then I agree with you!)  So if a source name has some other
form, it would be linted, and can be fixed with 'file-name' field.  I
think such consistency in source file names would be really great.

Apparently, this was your original propose (right?), now I support this
idea! :-)

-- 
Alex

  reply	other threads:[~2017-05-16 17:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06 12:51 bug#26802: Single source file emacs packages get a ".el.el" extension Arun Isaac
2017-05-09 19:38 ` Alex Kost
2017-05-11 19:19   ` Arun Isaac
2017-05-13  8:54     ` Alex Kost
2017-05-13 16:36       ` Arun Isaac
2017-05-14 17:15         ` Alex Kost
2017-05-15 13:28           ` Arun Isaac
2017-05-16 17:29             ` Alex Kost [this message]
2017-05-17 17:04               ` Arun Isaac
2017-05-21  9:03                 ` Alex Kost
2017-05-13  5:23 ` bug#26802: [PATCH 1/3] gnu: emacs-goto-chg: Set source file-name Arun Isaac
2017-05-13  8:55   ` Alex Kost
2017-05-17 16:52 ` bug#26802: [PATCH 1/4] gnu: lint: Fix typo Arun Isaac
2017-05-18 11:28   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a86czp5e.fsf@gmail.com \
    --to=alezost@gmail.com \
    --cc=26802@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).