From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBbuL-0008DQ-Hr
	for guix-patches@gnu.org; Fri, 19 May 2017 03:01:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBbuI-0000L5-9s
	for guix-patches@gnu.org; Fri, 19 May 2017 03:01:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:51597)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dBbuH-0000Ks-Vv
	for guix-patches@gnu.org; Fri, 19 May 2017 03:01:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dBbuH-0005yq-MU
	for guix-patches@gnu.org; Fri, 19 May 2017 03:01:01 -0400
Subject: bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images.
Resent-Message-ID: <handler.26815.B26815.149517722522935@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <87r2zoygoi.fsf@gnu.org>
	<20170517110522.18106-1-mbakke@fastmail.com>
	<20170517110522.18106-3-mbakke@fastmail.com> <87ziebtbph.fsf@gnu.org>
	<877f1ecf00.fsf@fastmail.com> <87inkxanzj.fsf@gnu.org>
	<87y3ttbwwj.fsf@fastmail.com>
Date: Fri, 19 May 2017 09:00:08 +0200
In-Reply-To: <87y3ttbwwj.fsf@fastmail.com> (Marius Bakke's message of "Fri, 19
	May 2017 00:52:28 +0200")
Message-ID: <87a869l4av.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26815@debbugs.gnu.org

Marius Bakke <mbakke@fastmail.com> skribis:

> Ludovic Court=C3=A8s <ludo@gnu.org> writes:
>
>>> From b2236aa915bfb32e974546790a1e87ef1b268403 Mon Sep 17 00:00:00 2001
>>> From: Marius Bakke <mbakke@fastmail.com>
>>> Date: Thu, 18 May 2017 18:10:31 +0200
>>> Subject: [PATCH] vm: Initialize-hard-disk now takes a grub-efi paramete=
r.
>>>
>>> * gnu/build/vm.scm (initialize-hard-disk): Learn #:grub-efi.
>>> (install-efi): Use it.
>>> * gnu/system/vm.scm (qemu-image): Pass it.
>>
>> LGTM!  I suppose you=E2=80=99d squash it with the initial patch?
>
> Indeed. Figured this was an easier review format, though.

Definitely.

> I'll push this series shortly, after some basic sanity checks. Thanks a
> lot for the great feedback! I'll work on a more Guixy way of creating
> the standalone GRUB image and also a system test for the next release ;-)

Awesome, thank you!

Ludo=E2=80=99.