From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43288)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dC0pr-0008OT-Nx
	for guix-patches@gnu.org; Sat, 20 May 2017 05:38:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dC0pm-0007n9-QM
	for guix-patches@gnu.org; Sat, 20 May 2017 05:38:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53314)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dC0pm-0007n4-MO
	for guix-patches@gnu.org; Sat, 20 May 2017 05:38:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dC0pm-00031b-HI
	for guix-patches@gnu.org; Sat, 20 May 2017 05:38:02 -0400
Subject: bug#26815: [PATCH v4 3/3] vm: Add UEFI loader to disk images.
Resent-Message-ID: <handler.26815.D26815.149527302511550@debbugs.gnu.org>
References: <87r2zoygoi.fsf@gnu.org>
	<20170517110522.18106-1-mbakke@fastmail.com>
	<20170517110522.18106-3-mbakke@fastmail.com> <87ziebtbph.fsf@gnu.org>
	<877f1ecf00.fsf@fastmail.com> <8737c2cbm5.fsf@fastmail.com>
	<871srlankf.fsf@gnu.org> <87k25cvn49.fsf@fastmail.com>
	<87pof4agte.fsf@gmail.com> <87h90gvhz3.fsf@fastmail.com>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87h90gvhz3.fsf@fastmail.com>
Date: Sat, 20 May 2017 11:36:56 +0200
Message-ID: <87a8673m4n.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26815-done@debbugs.gnu.org


Hi Marius,

> I plan to make a generic "grub-standalone" variant. Will try to fit it
> into the new bootloader API. The regular grub-efi variant won't cut it
> because it can't update EFI variables on the target system, so we need
> the "self-contained" grub snapshot generated by grub-mkstandalone(1).
>
> Also, the normal configuration file doesn't work with it, but a minimal
> config that loads the real one at boot is okay. Not sure why!

Ok, but don't we need to do it on system reconfigure too ?

>
>> For example the (when esp ...) snippet in initialize-hard-disk or the
>> install-efi procedure.
>
> Here, I plan on implementing an #:efi-loader keyword that is passed a
> gexp for the generated EFI firmware image, instead of the current
> approach that passes #:grub-efi and builds it outside the store.

Great !

>
> On a related topic: The "device" field for grub-efi is a noop;
> `grub-install` looks for "/boot/efi" only (or "--efi-directory").
> Currently the example uses the ESP for "device", but it should not have
> to be set. Not sure what to do about it, ideas?

The "device" field of <bootloader> defaults to #f so maybe you can skip
it ?

Mathieu