From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dE059-0006y2-Gu for guix-patches@gnu.org; Thu, 25 May 2017 17:14:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dE056-0004TZ-D9 for guix-patches@gnu.org; Thu, 25 May 2017 17:14:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35552) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dE056-0004TG-3j for guix-patches@gnu.org; Thu, 25 May 2017 17:14:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dE054-00040R-Cu for guix-patches@gnu.org; Thu, 25 May 2017 17:14:02 -0400 Subject: bug#27075: [PATCH] gnu: Add multitail Resent-Message-ID: From: Marius Bakke In-Reply-To: <87efvc3cbe.fsf@xsteve.at> References: <87efvc3cbe.fsf@xsteve.at> Date: Thu, 25 May 2017 23:13:52 +0200 Message-ID: <87a860vdv3.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Stefan =?UTF-8?Q?Reich=C3=B6r?= , 27075@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Reich=C3=B6r writes: > Hi there, > > I am not sure what category fits best for multitail. I have added it to > less as a first attempt. Thanks for this! I think "logging.scm" works well for this package. A few comments: > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-curses-lib > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (substitute* "mt.h" > + (("ncursesw\\/panel.h") "panel.h") > + (("ncursesw\\/ncurses.h") "ncurses.h"))) > + #t)) > + (delete 'configure) > + (delete 'check)))) ; no test suite (make check just runs cppche= ck) Instead of deleting the 'check' phase, you can set the #:tests? keyword to #f. > + (inputs `(("ncurses" ,ncurses))) > + (home-page "https://vanheusden.com/multitail/") > + (synopsis "Monitor multiple logfiles") > + (description > + "MultiTail allows you to monitor logfiles and command output in mul= tiple > +windows in a terminal, colorize, filter and merge.") > + (license gpl2))) When there is no version information indicated in the source code headers, we default to "or later" (i.e. gpl2+ in this instance). The rest LGTM. Can you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlknSRAACgkQoqBt8qM6 VPq2dwf+LCFAUXdct8/EENSHIO+KTuicytqRjH/PFF0eyNYQm73IHRLu5TJkk2ZX NVBzOX/H0k+kvEY8EvtmD6bGwvkZroZtbb97uja4rCik29JDVQ4Ix2dZ0qGWDcN3 VtrQBAxp6Ha63HJgY+99Ttit/XOARKitO8MFeu24HE+65Tq9iyG6JnOi2eQkvhCH +YJBpwEur87XPx38YvUt7CWrZMOe3tElkb6dCylgctyKBeaPJAARAnqsV6qb+q/E AElzKdq6ar3j2IFFY1iVhTHfW2N4t9XwQmTbtWQOxHn1o1K3F6czMDgchmhHxYIi RhmggAxbE9d0QchzHDttcUoKu45t6A== =ZeiY -----END PGP SIGNATURE----- --=-=-=--