unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: "Stefan Reichör" <stefan@xsteve.at>, 27075@debbugs.gnu.org
Subject: bug#27075: [PATCH] gnu: Add multitail
Date: Thu, 25 May 2017 23:13:52 +0200	[thread overview]
Message-ID: <87a860vdv3.fsf@fastmail.com> (raw)
In-Reply-To: <87efvc3cbe.fsf@xsteve.at>

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

Stefan Reichör <stefan@xsteve.at> writes:

> Hi there,
>
> I am not sure what category fits best for multitail. I have added it to
> less as a first attempt.

Thanks for this! I think "logging.scm" works well for this package. A
few comments:

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-curses-lib
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (substitute* "mt.h"
> +                 (("ncursesw\\/panel.h") "panel.h")
> +                 (("ncursesw\\/ncurses.h") "ncurses.h")))
> +             #t))
> +         (delete 'configure)
> +         (delete 'check)))) ; no test suite (make check just runs cppcheck)

Instead of deleting the 'check' phase, you can set the #:tests? keyword
to #f.

> +    (inputs `(("ncurses" ,ncurses)))
> +    (home-page "https://vanheusden.com/multitail/")
> +    (synopsis "Monitor multiple logfiles")
> +    (description
> +     "MultiTail allows you to monitor logfiles and command output in multiple
> +windows in a terminal, colorize, filter and merge.")
> +    (license gpl2)))

When there is no version information indicated in the source code
headers, we default to "or later" (i.e. gpl2+ in this instance).

The rest LGTM. Can you send an updated patch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2017-05-25 21:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-25 20:34 bug#27075: [PATCH] gnu: Add multitail Stefan Reichör
2017-05-25 21:13 ` Marius Bakke [this message]
2017-05-25 21:35   ` Stefan Reichör
2017-05-25 22:11     ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a860vdv3.fsf@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=27075@debbugs.gnu.org \
    --cc=stefan@xsteve.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).