Marius Bakke <mbakke@fastmail.com> writes:

Thanks for your review!

> Stefan Reichör <stefan@xsteve.at> writes:
>
>> Hi there,
>>
>> I am not sure what category fits best for multitail. I have added it to
>> less as a first attempt.
>
> Thanks for this! I think "logging.scm" works well for this package. A
> few comments:

o.k.

>> +       #:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'patch-curses-lib
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((out (assoc-ref outputs "out")))
>> +               (substitute* "mt.h"
>> +                 (("ncursesw\\/panel.h") "panel.h")
>> +                 (("ncursesw\\/ncurses.h") "ncurses.h")))
>> +             #t))
>> +         (delete 'configure)
>> +         (delete 'check)))) ; no test suite (make check just runs cppcheck)
>
> Instead of deleting the 'check' phase, you can set the #:tests? keyword
> to #f.
>
>> +    (inputs `(("ncurses" ,ncurses)))
>> +    (home-page "https://vanheusden.com/multitail/")
>> +    (synopsis "Monitor multiple logfiles")
>> +    (description
>> +     "MultiTail allows you to monitor logfiles and command output in multiple
>> +windows in a terminal, colorize, filter and merge.")
>> +    (license gpl2)))
>
> When there is no version information indicated in the source code
> headers, we default to "or later" (i.e. gpl2+ in this instance).

I read the LICENSE file (https://github.com/flok99/multitail/blob/master/LICENSE) and thought it is gpl2.
But I updated it to gpl2+ now.

>
> The rest LGTM. Can you send an updated patch?

Here is the updated patch: