unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mike Gerwitz <mtg@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27049@debbugs.gnu.org
Subject: bug#27049: [PATCH] gnu: Add mathjax.
Date: Mon, 29 May 2017 20:55:14 -0400	[thread overview]
Message-ID: <87a85vxix9.fsf@gnu.org> (raw)
In-Reply-To: <878tlf8xa4.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 29 May 2017 18:04:19 +0200")

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

On Mon, May 29, 2017 at 18:04:19 +0200, Ludovic Courtès wrote:
> Jelle Licht <jlicht@fsfe.org> skribis:
>> Another issue with minifiers in general is that is Very Hard to write a
>> proper minifier. If we choose to not use the minifier as expected by the
>> package author, we will at some point run into issues that will be very
>> hard to report and get fixed upstream, as it will only be us experiencing
>> these issues due to our ... unique .. build procedure.
>
> Sure.  My suggestion would be to use an existing, established minifier,
> only one that is relatively simple to package.  It could be one written
> in a language other than JS (Ricardo mentioned ‘cl-uglify-js’ on IRC),
> or it could be a simplistic minifier written in JS but with very few or
> not dependencies, if that exists.

Further, minifiers have various options and some methods are more
aggressive than others.  Last I checked a couple years ago, for example,
Closure Compiler broke GNU ease.js on its more aggressive setting.  The
break was obvious from running my test suite, but some breaks were
subtle and would have caused nightmares in production.  Perhaps things
have since improved.

My point is, though, that Jelle's concerns are shared.  Closure Compiler
is written by Google, and they tend to know what they're doing in this
area. ;)

I'm not saying I'm opposed; it sounds fine to me.  Just be careful!

-- 
Mike Gerwitz
Free Software Hacker+Activist | GNU Maintainer & Volunteer
GPG: D6E9 B930 028A 6C38 F43B  2388 FEF6 3574 5E6F 6D05
https://mikegerwitz.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

  parent reply	other threads:[~2017-05-30  0:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 21:43 bug#27049: [PATCH] gnu: Add mathjax Arun Isaac
     [not found] ` <handler.27049.B.149557583819622.ack@debbugs.gnu.org>
2017-05-24 10:09   ` bug#27049: Acknowledgement ([PATCH] gnu: Add mathjax.) Arun Isaac
2017-05-24 13:16     ` Brendan Tildesley
2017-05-28 19:41     ` Ludovic Courtès
2017-05-29 18:47       ` Arun Isaac
2017-05-24 14:47 ` bug#27049: [PATCH] gnu: Add mathjax Brendan Tildesley
2017-05-28 17:41   ` Ludovic Courtès
2017-05-28 18:44     ` Arun Isaac
2017-05-29  7:47     ` Brendan Tildesley
     [not found]     ` <ba2e770a.AEUAKlldotwAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZKxqe@mailjet.com>
2017-05-29  9:34       ` Ludovic Courtès
2017-05-29 11:13         ` Jelle Licht
2017-05-29 12:05           ` Ludovic Courtès
2017-05-29 12:26             ` Jelle Licht
2017-05-29 16:04               ` Ludovic Courtès
2017-05-29 19:19                 ` Arun Isaac
2017-05-30  0:55                 ` Mike Gerwitz [this message]
2017-06-02 20:33 ` bug#27049: [PATCH 1/2] gnu: Add font-mathjax Arun Isaac
2017-06-03 13:51   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a85vxix9.fsf@gnu.org \
    --to=mtg@gnu.org \
    --cc=27049@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).