From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27690@debbugs.gnu.org
Subject: [bug#27690] [PATCH] build: Allow mounting of entire disks.
Date: Mon, 17 Jul 2017 11:28:25 +0200 [thread overview]
Message-ID: <87a843cszq.fsf@gnu.org> (raw)
In-Reply-To: <20170714083215.9889-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Fri, 14 Jul 2017 10:32:15 +0200")
Hello,
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> * gnu/build/file-systems.scm (disk-partitions): Also return entire drives.
In the subject line, please write “file-systems:” instead of “build:”
(the latter is for Makefile and configury.)
> --- a/gnu/build/file-systems.scm
> +++ b/gnu/build/file-systems.scm
> @@ -377,11 +377,14 @@ not valid header was found."
> (string-ref str (- (string-length str) 1)))
>
> (define (partition? name major minor)
> - ;; Select device names that end in a digit, like libblkid's 'probe_all'
> - ;; function does. Checking for "/sys/dev/block/MAJOR:MINOR/partition"
> - ;; doesn't work for partitions coming from mapped devices.
> - (and (char-set-contains? char-set:digit (last-character name))
> - (> major 2))) ;ignore RAM disks and floppy disks
> + ;; grub-mkrescue does some funny things for EFI support which
> + ;; makes it a lot more difficult than one would expect to support
> + ;; booting an ISO-9660 image from an USB flash drive.
> + ;; For example there's a buggy (too small) hidden partition in it
> + ;; which Linux rightfully refuses to mount.
> + ;; In any case, partition tables are supposed to be optional so
> + ;; here we allow checking entire disks for file systems, too.
> + (> major 2)) ;ignore RAM disks and floppy disks
I think you can remove ‘last-character’ and keep the comment about
/sys/dev/block.
Have you tested that this doesn’t cause any problems on actual hardware,
like matching things that should really be skipped, and then causing
failures down the road in label/UUID code?
Also, it seems that we’d be departing from what libblkid is doing, per
the comment above. To me that raises a flag, though if we really need
it that’s fine of course.
Thoughts? :-)
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-07-17 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 8:32 [bug#27690] [PATCH] build: Allow mounting of entire disks Danny Milosavljevic
2017-07-17 9:28 ` Ludovic Courtès [this message]
2017-09-05 13:22 ` bug#27690: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a843cszq.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27690@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).