unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Christopher Baines <mail@cbaines.net>
Cc: 27977-done@debbugs.gnu.org
Subject: [bug#27977] [PATCH 1/2] services: herd: Fix matching ok responses from shepherd service.
Date: Wed, 23 Aug 2017 00:30:21 +0200	[thread overview]
Message-ID: <87a82rnsle.fsf@gnu.org> (raw)
In-Reply-To: <20170822174452.3784d96c@cbaines.net> (Christopher Baines's message of "Tue, 22 Aug 2017 17:44:52 +0100")

Christopher Baines <mail@cbaines.net> skribis:

> On Tue, 22 Aug 2017 17:52:44 +0200
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> Probably this patch is better than reverting.
>> 
>> Thoughts?
>
> I had to apply that patch with --ignore-whitespace-change, as the code
> in the middle of (current-services) has been indented outside of that
> patch.

Right, sorry about that (I have -bB in ‘vc-diff-switches’).

> I think I get what is going on. As far as I understand it, the (match
> results ((services _ ...) ... bit is equivilent to the use of first in
> the other procedures, which suggests to me that you could use first in
> (current-services)? I'm guessing that the only difference is that they
> will fail differently on the empty list?

Yes.  I’ve pushed it as 7d14082d56462f7bef4254d65a21fd265fbce471.

Thanks,
Ludo’.

      reply	other threads:[~2017-08-22 22:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-05 21:26 [bug#27977] [PATCH] services: herd: Fix matching ok responses and add stop service procedure Christopher Baines
2017-08-05 21:30 ` [bug#27977] [PATCH 1/2] services: herd: Fix matching ok responses from shepherd service Christopher Baines
2017-08-05 21:30   ` [bug#27977] [PATCH 2/2] services: herd: Add a stop-service procedure Christopher Baines
2017-08-08  8:14     ` Danny Milosavljevic
2017-08-08 19:53       ` bug#27977: " Christopher Baines
2017-08-08  8:16   ` [bug#27977] [PATCH 1/2] services: herd: Fix matching ok responses from shepherd service Danny Milosavljevic
2017-08-22 12:39   ` Ludovic Courtès
2017-08-22 15:52   ` Ludovic Courtès
2017-08-22 16:44     ` Christopher Baines
2017-08-22 22:30       ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a82rnsle.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=27977-done@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).