From: Roel Janssen <roel@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 27907@debbugs.gnu.org
Subject: [bug#27907] [PATCH] graph: Provide access to the package record in the emit
Date: Fri, 25 Aug 2017 18:19:36 +0200 [thread overview]
Message-ID: <87a82ntyav.fsf@gnu.org> (raw)
In-Reply-To: <87r2vzg0qb.fsf@gnu.org>
Ludovic Courtès writes:
> Roel Janssen <roel@gnu.org> skribis:
>
>> Oops! I am sorry about this. Would it not break if we include a check for whether
>> the node type is a package or not. Then, non-package node types are
>> handled the “old way” and packages are handled the “new way”.
>>
>> I think we cannot have a generic way of exposing the specifics of a node
>> type, so if we need to expose more information for the other node types,
>> we have to add a type-specific implementation.
>
> Actually, we might need to discuss the specifics of why you wanted to do
> it in the first place. :-)
>
> It is to pass extra rendering info to the backends? (It would be
> helpful for instance to adjust the node color or size depending on
> certain parameters such as its size or number of dependents.)
Not necessarily rendering information, even though it could improve the
displayment of packages like you say. I'd like to export more
information to a graph database, so that the packages can be searched,
explored and linked to in a graph that also contains stuff like how
programs were run and what files that run produced.
So, this is essentially an interoperability thing for communicating with
other systems.
>
>> If this sounds like a good idea I'll write a new patch. And while I'm
>> at it, what set of commands fully cover the graph code for all node
>> types? Just all variants in 'guix graph --type=X'?
>
> “make check TESTS=tests/graph.scm” covers all the node types I think.
>
> Ludo’.
Then I will run that command before I propose a new patch.
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2017-08-25 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 14:40 [bug#27907] [PATCH] graph: Provide access to the package record in the emit Roel Janssen
2017-08-01 19:25 ` Ludovic Courtès
2017-08-01 22:47 ` bug#27907: " Roel Janssen
2017-08-24 22:26 ` [bug#27907] " Ludovic Courtès
2017-08-25 9:00 ` Roel Janssen
2017-08-25 14:50 ` Ludovic Courtès
2017-08-25 16:19 ` Roel Janssen [this message]
2017-08-26 8:02 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a82ntyav.fsf@gnu.org \
--to=roel@gnu.org \
--cc=27907@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).