From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ehvFp-0004s3-Fw for guix-patches@gnu.org; Sat, 03 Feb 2018 05:41:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ehvFm-0002zw-DF for guix-patches@gnu.org; Sat, 03 Feb 2018 05:41:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:47053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ehvFm-0002zZ-8n for guix-patches@gnu.org; Sat, 03 Feb 2018 05:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ehvFl-0004OO-Qu for guix-patches@gnu.org; Sat, 03 Feb 2018 05:41:01 -0500 Subject: [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support. Resent-Message-ID: From: Oleg Pykhalov References: <87o9n3kgez.fsf@gmail.com> <87608qd964.fsf@fastmail.com> <87y3kexfb4.fsf@gmail.com> <87wozyoyqx.fsf@fastmail.com> Date: Sat, 03 Feb 2018 13:40:26 +0300 In-Reply-To: <87wozyoyqx.fsf@fastmail.com> (Marius Bakke's message of "Wed, 31 Jan 2018 16:04:54 +0100") Message-ID: <87a7wq9x0l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 29678@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> "Marius" =3D=3D Marius Bakke writes: > I see pulseaudio is already in Qemus closure, I used `guix size > qemu | grep pulseaudio`. However "qemu-minimal" does not include > pulseaudio, which increases the size by about 25%. Can you drop > the input from qemu-minimal at the same time? For some unknown to me reason, =E2=80=9Cqemu-minimal=E2=80=9D closure doesn= 't contain =E2=80=9Cpulseaudio=E2=80=9D according to my investigation: =2D-8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix size qemu-minimal store item total s= elf /gnu/store/30sahk57a45xx205n7mmv3xcpch51g08-qemu-minimal-2.10.2 185.3 = 66.6 35.9% /gnu/store/n6nvxlk2j8ysffjh3jphn1k5silnakh6-glibc-2.25 38.5 = 37.1 20.0% /gnu/store/3x53yv4v144c9xp02rs64z7j597kkqax-gcc-5.4.0-lib 68.6 = 30.1 16.2% /gnu/store/azbfh3i72lbaqvhgg5m7p6ymmqq0ii6q-glib-2.52.3 111.9 = 13.8 7.5% /gnu/store/zbywrj6klakskj0sppq56viqh9l56jl0-util-linux-2.30.1 87.7 = 12.1 6.5% /gnu/store/09j7scnl3hahcmql986fsjpzj6gqsmzv-ncurses-6.0 74.3 = 5.7 3.1% /gnu/store/b7y66db86k57vbb03nr4bfn9svmks4gf-bash-4.4.12 81.0 = 5.4 2.9% /gnu/store/an52j0jrvd23qypbidd5f20k2wi75vh9-pcre-8.40 72.1 = 3.4 1.9% /gnu/store/2p1ljs69x19v11r0rgqh7k3v6ggfqizq-libjpeg-turbo-1.5.3 72.0 = 3.4 1.8% /gnu/store/w8kii3hjvmh50yxs52gkdywkq9jc7s19-pixman-0.34.0 70.2 = 1.6 0.9% /gnu/store/zhrajv6qf2hzn9c3g2bb07559hyrz5xp-bash-static-4.4.12 1.4 = 1.4 0.8% /gnu/store/mipizipnr4y2hly9b429j8id1albbgqi-readline-7.0 75.6 = 1.3 0.7% /gnu/store/kpxi8h3669afr9r1bgvaf9ij3y4wdyyn-bash-minimal-4.4.12 39.5 = 1.0 0.5% /gnu/store/vdqy6r4g7357nsjjh4d1gfqj9hhw1vk8-libseccomp-2.3.2 69.5 = 0.8 0.5% /gnu/store/b9ww6qv1ii9v6n45kin7543vkf6jfnd3-libpng-1.6.29 70.8 = 0.8 0.4% /gnu/store/sfx1wh27i6gsrk21p87rdyikc64v7d51-zlib-1.2.11 69.0 = 0.4 0.2% /gnu/store/jnbb8ffxxvrw2b4z18zn0g08kqk9rsgl-libffi-3.2.1 68.8 = 0.1 0.1% /gnu/store/hxn2viwl04nwswpjkfg0iyyhm815yaza-libcap-2.25 68.8 = 0.1 0.1% /gnu/store/fq4zk6aqrgim67aiqri37vbbk4gdkfny-libaio-0.3.110 0.0 = 0.0 0.0% total: 185.3 MiB =2D-8<---------------cut here---------------end--------------->8--- I could assume because =E2=80=9C(package-arguments qemu-minimal)=E2=80=9D s= hows a totally different =E2=80=9C#:configure-flags=E2=80=9D than =E2=80=9C(packag= e-arguments qemu)=E2=80=9D. Particularly doesn't contain =E2=80=9C--audio-drv-list=3Dalsa,pa,sdl=E2=80= =9D. > Unfortunately we might have to override #:configure-flags as well. No (see above). >> + (string-append "--audio-drv-list=3D" >> + (string-join (list "alsa" "pa" "sdl") ","))) > Nit-pick: I don't really see the benefit of using string-join > here. Agree. > But no strong opinion. However: use '() instead of (list > ...) when the elements do not need to be evaluated. Thanks, I will use a quote. Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlp1kZoACgkQckbhHGm3 lWntjBAAspD49AObpZVlbYZ3cPVAyhBO0q0+Tg8ObCmiZeJ5fMCNH/UC9qL7kepB TMKS4Gtn+MO2YdZbmXs7ZVeWCed7gVAr0DqbbJx5HD47ET+uK7E4C11zexkmCQ+3 T662Ndo1v2o/v8/pCnMRzTPB0YiW2eJQ0KDyAcwGDzs8P9rTj0G8BzlGxlXZ7691 YPFOxW30WcMeno6AMa6lCcfwzpWDirAdrglWRbsWtgsTnCHoIsJDatFmS5+IU4lT 9E0mFsfvxsBt0sfN9p0LVQJdcnJ9FPETk+3ZP/L30n56meSkNRPYWD+CfpdPWuL4 fg+bZPeuPZ6XWVp6/phJN7Cb/kWSCMpQuHp/PXkOXE08eUlTwl8ZDJLHjjZtGZr8 3NUB1pzwn9UVNRl+zi1FI9TTP0w0aX79zCeXe8xCu8kkxnsK4zLP/1dqt6k2QHgv P8vmzus0q47LuyAcnCu3/7m7eFrEqo4sD4LxH0/zwe53J4tXqCFtKeXxt+YdCdan b7ADPZYdO4c1Zs6YNfyTGvKfF/sUvqcbttG3poQ9KFE9tzfH9uAvF61XBiOmj+nx xCdvdp2OXsVgTeeZnkWGRtRbR1FtjIYGsWF5Hz/DbUSjLPhDGq4s7Eg0w4QFNvOB x02EyukpYVZEaSkgx08ZgZd83mDw72XkS7Zhz1sdguoMgRa39zg= =FGse -----END PGP SIGNATURE----- --=-=-=--