From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evJS7-0003xE-9o for guix-patches@gnu.org; Mon, 12 Mar 2018 05:09:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evJS2-0008DD-5t for guix-patches@gnu.org; Mon, 12 Mar 2018 05:09:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evJS2-0008CN-24 for guix-patches@gnu.org; Mon, 12 Mar 2018 05:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evJS1-00022D-OK for guix-patches@gnu.org; Mon, 12 Mar 2018 05:09:01 -0400 Subject: [bug#30351] [PATCH] gnu: mcron2: Correct and enhance the wrap phase. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <874lmwwkgn.fsf@gmail.com> <87h8qq4gpg.fsf@gnu.org> <87d10af8fg.fsf@gmail.com> Date: Mon, 12 Mar 2018 10:08:02 +0100 In-Reply-To: <87d10af8fg.fsf@gmail.com> (Maxim Cournoyer's message of "Sun, 11 Mar 2018 20:23:47 -0400") Message-ID: <87a7vdslu5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Maxim Cournoyer Cc: 30351-done@debbugs.gnu.org Hi Maxim, Maxim Cournoyer skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Hi Maxim, >> >> Maxim Cournoyer skribis: >> >>> As a follow up to my previous patch to mcron2, this completes the wrap >>> phases and fix a small issue where the mcron modules were installed to >>> share/guile/site/2.0 instead of 2.2. >> >> Good catch. I=E2=80=99ve committed that change separately. >> >> BTW, I encourage you to submit changes to bug-mcron@gnu.org. Mcron is >> now maintained by Mathieu Lirzin, who is familiar with current Guile and >> certainly interested in receiving improvements like this. >> >> (Another thing that should be done would be install .go files in >> $libdir/guile/2.2/site-ccache.) > > It's already all fixed upstream! I verified myself. I guess we could > poke Mathieu for a new release ;). Definitely! It=E2=80=99s great that Mathieu has taken care of all this. >> So overall I think I=E2=80=99m arguing for the status quo. Would that w= ork for >> you? > > I'm happy with status quo as well. Thanks for lending your sharp eyes to > this review! Heheh, you=E2=80=99re welcome. I hope I=E2=80=99ll get around to adding th= at =E2=80=98with-extensions=E2=80=99 thing soonish, because =E2=80=98add-to-lo= ad-path=E2=80=99 is not as convenient as we=E2=80=99d like. Thanks, Ludo=E2=80=99.