From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXXIP-0004lR-Aj for guix-patches@gnu.org; Mon, 25 Jun 2018 15:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXXIM-0001E5-5r for guix-patches@gnu.org; Mon, 25 Jun 2018 15:37:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXXIM-0001Dz-0v for guix-patches@gnu.org; Mon, 25 Jun 2018 15:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXXIL-0005O7-Qs for guix-patches@gnu.org; Mon, 25 Jun 2018 15:37:01 -0400 Subject: [bug#31954] [PATCH] gnu: Add emacs-org-brain. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180624092937.19959-1-va511e@yahoo.com> References: <20180624092937.19959-1-va511e@yahoo.com> Date: Mon, 25 Jun 2018 21:36:31 +0200 Message-ID: <87a7riek00.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vasile Dumitrascu , 31954@debbugs.gnu.org --=-=-= Content-Type: text/plain Vasile Dumitrascu writes: > * gnu/packages/emacs.scm (emacs-org-brain): New variable. Thanks for this patch! Overall it LGTM, but it does not apply to my git checkout, so here are some nitpicks that I'd normally fix myself: [...] > +(define-public emacs-org-brain > + (let ((version "20180522") ; no proper tag, use date of commit 'org-brain.el' has "Version: 0.5" in the source header. Perhaps we should use that instead? [...] > + (description "@code{emacs-org-brain} implements a variant of concept > +mapping in Emacs, using @code{org-mode}. It is heavily inspired by a piece of > +software called The Brain.") Make sure to use double spaces in descriptions (guix lint should complain about this). We also should not refer to nonfree software, can you try to expand on this description without mentioning the inspiration? The commentary inside 'org-brain.el' contains a pretty good description. Can you send an updated patch please? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsxRD8ACgkQoqBt8qM6 VPpF4Qf/doY8bi54jCwjELlkL0PQwF+hvE0P1F1XRQCj7q9RliTk3MlVyfbGUx0Q vhzzxTpbiFacytRwSgcH8cZ+/l95yiBqamfxKKJWR49/6M2BnEMAofOMXK6A2vlc lbISuWgi8BMjAiBGNWf+7woytyJrrcuK/2Kh/jEr30EaaWT6EBxpXqK+ihW7OwM2 doMTDt6OnhT7wEMAE7b1W526V/3jBOrH5O2GWD7XgykscBLLGSgFvMl2emWo96hl fKYB2RVJBlidxufLf3To4HnA49hlvuWI4JmfFUGqlmGW5n1v6p1EEzOD9ux5M6LD wA3PDLgDuHcWFYk8S4b9N5AEPyKYFA== =Q1DH -----END PGP SIGNATURE----- --=-=-=--