From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flnz4-00066z-Ft for guix-patches@gnu.org; Sat, 04 Aug 2018 00:16:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flnz0-0002DN-FZ for guix-patches@gnu.org; Sat, 04 Aug 2018 00:16:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flnz0-0002DD-AP for guix-patches@gnu.org; Sat, 04 Aug 2018 00:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1flnyz-0007py-V9 for guix-patches@gnu.org; Sat, 04 Aug 2018 00:16:01 -0400 Subject: [bug#32358] Add pcscd service Resent-Message-ID: From: Chris Marusich References: Date: Fri, 03 Aug 2018 21:15:37 -0700 In-Reply-To: (Arun Isaac's message of "Fri, 03 Aug 2018 15:53:02 +0530") Message-ID: <87a7q2lqc6.fsf@garuda.local.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 32358@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Arun, Thank you for submitting a patch! I've been wanting something like this for a long time, so I'm very happy to see it. I'll test it out and let you know if it works for me. Arun Isaac writes: > diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-toke= n.scm > index 7fdcaaf1e..424f4626e 100644 > --- a/gnu/packages/security-token.scm > +++ b/gnu/packages/security-token.scm > > [...] > > @@ -169,13 +171,16 @@ the low-level development kit for the Yubico YubiKe= y authentication device.") > "1jc9ws5ra6v3plwraqixin0w0wfxj64drahrbkyrrwzghqjjc9ss"))= )) > (build-system gnu-build-system) > (arguments > - `(#:configure-flags '("--enable-usbdropdir=3D/var/lib/pcsc/drivers" > - "--disable-libsystemd"))) > + `(#:configure-flags > + (list (string-append "--enable-usbdropdir=3D" > + (assoc-ref %build-inputs "ccid") "/pcsc/driv= ers") > + "--disable-libsystemd"))) If someone was relying on the previous behavior (in which pcsc-lite would look in /var/lib/pcsc/drivers for drivers), this would break for them if they were using anything other than the ccid drivers, right? However, I understand that previous Guix email threads have talked about adding a symlink there which points to ccid's drivers (I do that today, myself), so I can see why you would want to make this change. > @@ -186,6 +191,16 @@ from a client application and provide access to the = desired reader.") > license:isc ; src/strlcat.c src/strl= cpy.c > license:gpl3+)))) ; src/spy/* >=20=20 > +(define pcsc-lite-bootstrap > + (package > + (inherit pcsc-lite) > + (name "pcsc-lite-bootstrap") > + (inputs > + `(("libudev" ,eudev))) > + (arguments > + (substitute-keyword-arguments (package-arguments pcsc-lite) > + ((#:configure-flags _) '(list "--disable-libsystemd")))))) > + What problem does this pcsc-lite-bootstrap package solve? It looks like you added pcsc-lite-bootstrap in order to avoid a cyclic dependency between ccid and pcsc-lite. That seems fair, but is there any other reason that I'm missing? > Subject: [PATCH 2/2] gnu: services: Add pcscd service. Do you know what the intent behind the --enable-usbdropdir option is in (1) the pcsc-lite configure script and (2) the ccid configure script? I checked the README in the source for both of these packages, but I couldn't quite understand the intended use. It wasn't clear to me if the usbdropdir directory is where the ccid/pcsc-lite expect to _find_ drivers that the user makes available, or if this directory is where the packages will _install_ their own drivers (or both, perhaps). If the usbdropdir is intended to house additional drivers that the user can "drop" in and use at runtime, then users of pcsc-lite/ccid might reasonably expect to be able to easily add additional drivers to the default configuration. If that's the case, then we might want to think about how we can give a user the ability to configure additional drivers. For example, if we gave the pcsc service configuration a field like "usbdropdir-drivers" (e.g. a list of packages or file-like objects), we could arrange for the union of those drivers to be placed into the usbdropdir for pcsc/ccid to use. Of course, I might be totally misunderstanding the intended use of the =2D-enable-usbdropdir configuration option. If that's the case, please let me know. What do you think? =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAltlKGkACgkQ3UCaFdgi Rp0kCBAA1/He5Jov+rQnse8+oi0vBKnmdhkYY6a3khFAzaCugsvjmrYh/n1lSJCI o//BcKaEARFGuWhYY4dIVDROg5g4o9TCdUcyex9V/6HWOGCMa8QfLw1/QA2Tja5E TKibHn9eYLIBaxPqEbVudKmc3Zyt1HmNMQ5QP4SzlAOBU4CtZe5EALvL63Cfyt1W zB8E9pcx/vEuZhzULCygaiJbdAC9apgqfP2mYOtULJfsNwVZNXujt2n1lbh6ESJn +26SdkNIYR+tQNbawHMWEFx6oNNHkBp6x5Jsj8zXar2/mkcaSDLel5Gz/9jE0JTJ ZUGaHwEB0BrxICyxCrqBS7iWPxdgRtL5e9rdQfMTrjvUQJyBq4/JURy63Te/1iFK USyQbV0mnsalp6E/qpb6lbdWyv2IkixCnMm7bcYKev+tmEB8xdnceSkU/Fxqb/P/ zAiahE9FE72PKlcmyrmkcEA3Oacu6Gi+YyEU5hSN4F95TvWVdv+ounM6IcNTJq+g RYUMbxdwTMZNkTnmbgNpYtRy6R7D2knvRDWcMUuwiQUMJ+8X2lufUn/LTBMx/8mv OmM2xCyW7HGyo+l5N/y3hdP0TxvaZXouc2ENuxBcj/v3iWfcKWXRTHr17qMWJExZ E98NXWGzRVziBLwWtmdyinIIEgM/2VwCculOgBPDaRYoXoo0Xrc= =Ebd+ -----END PGP SIGNATURE----- --=-=-=--