From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4PxB-0000sV-Jp for guix-patches@gnu.org; Mon, 24 Sep 2018 08:27:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4Px8-0002V5-Dx for guix-patches@gnu.org; Mon, 24 Sep 2018 08:27:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:47184) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4Px8-0002Uz-9v for guix-patches@gnu.org; Mon, 24 Sep 2018 08:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g4Px8-0003et-5y for guix-patches@gnu.org; Mon, 24 Sep 2018 08:27:02 -0400 Subject: [bug#32802] [PATCH] gnu: gnucash: Update to 3.2. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180922052514.25030-1-kkebreau@posteo.net> Date: Mon, 24 Sep 2018 14:26:28 +0200 In-Reply-To: <20180922052514.25030-1-kkebreau@posteo.net> (Kei Kebreau's message of "Sat, 22 Sep 2018 01:25:14 -0400") Message-ID: <87a7o7w07f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau Cc: 32802@debbugs.gnu.org Hello, Kei Kebreau skribis: > * gnu/packages/patches/gnucash-disable-failing-tests.patch: New file. > * gnu/local.mk (dist_patch_DATA): Register it. > * gnu/packages/gnucash.scm (gnucash): Update to 3.2. > [source]: Add patch. > [arguments]: Add 'glib-or-gtk-compile-schemas' and 'glib-or-gtk-wrap' pha= ses.. [...] > --- /dev/null > +++ b/gnu/packages/patches/gnucash-disable-failing-tests.patch > @@ -0,0 +1,39 @@ > +diff -ur gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt gnuc= ash-3.2/libgnucash/backend/xml/test/CMakeLists.txt > +--- gnucash-3.2.old/libgnucash/backend/xml/test/CMakeLists.txt 2018-09-1= 6 22:07:42.445865806 -0400 > ++++ gnucash-3.2/libgnucash/backend/xml/test/CMakeLists.txt 2018-09-16 22= :08:29.246608711 -0400 Please add couple of lines at the top explaining what the patch does and roughly what the problem is with these tests. > +-gnc_add_test(test-gnc-timezone "${test_gnc_timezone_SOURCES}" > +- gtest_engine_INCLUDES gtest_old_engine_LIBS) Could it be that you need =E2=80=98tzdata-for-tests=E2=80=99 as an input, w= ith TZDIR set accordingly? Otherwise LGTM, thanks! Ludo=E2=80=99.