From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41063) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNFjk-0003uR-28 for guix-patches@gnu.org; Thu, 15 Nov 2018 06:23:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNFji-0002Pl-4N for guix-patches@gnu.org; Thu, 15 Nov 2018 06:23:04 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:48789) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gNFjh-0002PM-VV for guix-patches@gnu.org; Thu, 15 Nov 2018 06:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gNFjh-0002av-QL for guix-patches@gnu.org; Thu, 15 Nov 2018 06:23:01 -0500 Subject: [bug#33080] [PATCH] gnu: Add inferno. In-Reply-To: <87bm7sjmfc.fsf@GlaDOS.home> Resent-Message-ID: From: Diego Nicola Barbato References: <87bm7sjmfc.fsf@GlaDOS.home> <87lg60yfir.fsf@gnu.org> Date: Thu, 15 Nov 2018 12:22:43 +0100 Message-ID: <87a7mazit8.fsf@GlaDOS.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33080@debbugs.gnu.org Hello Ludo, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi Diego, > > Sorry for the late reply. > > Diego Nicola Barbato skribis: > >> This patch adds inferno as discussed here: >> https://lists.gnu.org/archive/html/guix-devel/2018-10/msg00031.html > > In that thread we discussed the font issue, and I=E2=80=99m unsure if it = was > resolved: > > > > Is everything =E2=80=9Cknown good=E2=80=9D with this version of the patch? Unfortunately it is not. As you suggested, I wrote to the GNU/Linux-libre mailing list asking for advice on the font issues [1] and the licensing issues [2]. The only reply I got so far is not very encouraging. Maybe it is best to put this on hold until I receive more information? >> From c97b28e97a210cc31e34c08bc1abdc8bd74114fa Mon Sep 17 00:00:00 2001 >> From: Diego Nicola Barbato >> Date: Wed, 17 Oct 2018 23:07:40 +0200 >> Subject: [PATCH] gnu: Add inferno. >> >> * gnu/packages/inferno.scm: New file. >> * gnu/local.mk (GNU_SYSTEM_MODULES): Register it. > > Overall it LGTM! Minor suggestions here: > >> + #:phases >> + (let* ((bash (assoc-ref %build-inputs "bash")) >> + (objtype ,@(match (%current-system) >> + ((or "armhf-linux" "aarch64-linux") >> + `("arm")) >> + (_ >> + `("386")))) >> + (out (assoc-ref %outputs "out")) >> + (root (string-append out "/share/inferno")) >> + (root/bindir (string-append root "/Linux/" >> + objtype "/bin")) >> + (bindir (string-append out "/bin")) >> + (infwm-script (string-append bindir "/infwm"))) >> + `(,(assoc 'set-paths %standard-phases) >> + (unpack . ,(lambda* (#:key source #:allow-other-keys) > > For consistency, I would very much prefer if we could use > =E2=80=98modify-phases=E2=80=99 here, which is what is used throughout gn= u/packages. > If that=E2=80=99s fine with you, could you update the patch? > >> + (synopsis >> + "Compact operating system for building cross-platform distribute= d systems") > > Maybe shorten to =E2=80=9COperating system for building distributed syste= ms=E2=80=9D? If it is OK I will wait for the font and licensing issues to be resolved before I update the patch, since, as of now, it looks to me like Inferno can not be included in an FSDG distro.=20 Thanks for the feedback and I am sorry this turned out to be more complicated than I anticipated. Diego [1]: https://lists.nongnu.org/archive/html/gnu-linux-libre/2018-11/msg00000= .html [2]: https://lists.nongnu.org/archive/html/gnu-linux-libre/2018-11/msg00001= .html