From: Marius Bakke <mbakke@fastmail.com>
To: Robert Smith <robertsmith@posteo.net>, 34904-done@debbugs.gnu.org
Subject: bug#34904: [PATCH] Update elixir to 1.8.1.
Date: Thu, 21 Mar 2019 20:54:51 +0100 [thread overview]
Message-ID: <87a7ho0zqs.fsf@fastmail.com> (raw)
In-Reply-To: <e357782862cf96e2eeeb064e9ceea279@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi Robert,
Robert Smith <robertsmith@posteo.net> writes:
> Hello,
>
> Excited to be submitting my first patch to guix!
It's a thrill, right? :-)
> The following patch updates elixir from 1.6.6 to 1.8.1.
> This was almost a trivial patch, however the full path of the git
> executable
> was causing a line to go over 80 chars, which caused a syntax check in
> the
> elixir Makefile to fail. I added a quick workaround to use elixir's own
> syntax
> checker to fix the affected file (by putting each argument to the fn on
> its own line)
> before the test is run.
Heh. Nice workaround! I added a commit message that follows our
convention, added the patch to "gnu/local.mk", and pushed the patch
in commit 2f87048dbe14097b9fe19ec470e2628cfca7fdbf.
Thank you, and welcome!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2019-03-21 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 14:54 [bug#34904] [PATCH] Update elixir to 1.8.1 Robert Smith
2019-03-21 19:54 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7ho0zqs.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=34904-done@debbugs.gnu.org \
--cc=robertsmith@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).