unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 35935@debbugs.gnu.org
Subject: [bug#35935] [PATCH] guix: import: simplify recursive import
Date: Sun, 02 Jun 2019 21:52:45 +0200	[thread overview]
Message-ID: <87a7ez933m.fsf@gnu.org> (raw)
In-Reply-To: <20190527200731.59990-1-rob@vllmrt.net> (Robert Vollmert's message of "Mon, 27 May 2019 22:07:31 +0200")

Hello Robert,

Robert Vollmert <rob@vllmrt.net> skribis:

> This simplifies the logic of recursive-import, intending no
> major functional changes. The package import function is no
> longer called twice per package. Failed imports now make it
> to the package stream as '() instead of #f.
>
> * guix/import/utils.scm: Simplify recursive-import.
                         ^
Minor issue: please make sure to mention the modified entities here
(procedures, variables, etc.); see
<https://www.gnu.org/prep/standards/html_node/Change-Logs.html>.

I think Oleg worked on this part before; Oleg, could you comment
and/or apply?

‘tests/import-utils.scm’ doesn’t seem to be testing this procedure,
perhaps that’s something we should fix eventually.

Thanks,
Ludo’.

  reply	other threads:[~2019-06-02 19:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 20:07 [bug#35935] [PATCH] guix: import: simplify recursive import Robert Vollmert
2019-06-02 19:52 ` Ludovic Courtès [this message]
2019-06-02 20:23   ` Robert Vollmert
2019-06-03 19:56     ` Oleg Pykhalov
2019-06-03 19:59       ` Robert Vollmert
2019-06-03 20:31         ` bug#35935: " Oleg Pykhalov
2019-06-02 20:19 ` [bug#35935] [PATCH] guix: import: Simplify " Robert Vollmert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7ez933m.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=35935@debbugs.gnu.org \
    --cc=rob@vllmrt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).