From: "Ludovic Courtès" <ludo@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 35895@debbugs.gnu.org
Subject: [bug#35895] [PATCH] linux-container: Remove networking service when network is shared with host.
Date: Thu, 13 Jun 2019 23:02:26 +0200 [thread overview]
Message-ID: <87a7el19nh.fsf@gnu.org> (raw)
In-Reply-To: <cu7zhmqebur.fsf@systemreboot.net> (Arun Isaac's message of "Mon, 10 Jun 2019 02:05:08 +0530")
Hello,
Arun Isaac <arunisaac@systemreboot.net> skribis:
> From a7b795d9af3347330b48470d3988d43b8038c2c1 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Sat, 25 May 2019 11:49:42 +0530
> Subject: [PATCH] linux-container: Remove networking service when network is
> shared with host.
>
> * gnu/system/linux-container.scm (dummy-networking-shepherd-service): New
> procedure.
> (dummy-networking-service-type): New variable.
> (containerized-operating-system): If network is shared with host, replace
> static-networking-service-type with dummy-networking-service-type.
[...]
> +(define dummy-networking-shepherd-service
> + (shepherd-service
> + (documentation "Provide loopback and networking without actually doing
> +anything.")
> + (provision '(loopback networking))
> + (start #~(const #t))))
> +
> +(define dummy-networking-service-type
> + (service-type
> + (name 'dummy-networking)
> + (extensions
> + (list (service-extension
> + shepherd-root-service-type
> + (const (list dummy-networking-shepherd-service)))))
> + (default-value #f)))
You can use ‘shepherd-service-type’ as a shorthand for these two
definitions.
> + (services (append
> + (remove (lambda (service)
> + (memq (service-kind service)
> + useless-services))
> + (operating-system-user-services os))
> + ;; Many Guix services depend on a 'networking' shepherd
> + ;; service, so make sure to provide a dummy 'networking'
> + ;; service when we are sure that networking is already set up
> + ;; in the host and can be used. That prevents double setup.
> + (if shared-network?
> + (list (service dummy-networking-service-type))
> + (list))))
I’m really nitpicking here, but I like to have the first argument to
‘append’ on the same line, and I also visually recognize '() more easily
than (list).
Anyway, LGTM!
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-06-13 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 7:01 [bug#35895] [PATCH 0/1] linux-container: Remove networking service when network is shared with host Arun Isaac
2019-05-25 7:20 ` [bug#35895] [PATCH] " Arun Isaac
2019-05-25 12:37 ` Christopher Baines
2019-06-03 17:11 ` Danny Milosavljevic
2019-06-09 20:35 ` Arun Isaac
2019-06-13 21:02 ` Ludovic Courtès [this message]
2019-06-18 11:37 ` Arun Isaac
2019-06-18 14:19 ` Ludovic Courtès
2019-06-18 18:57 ` bug#35895: " Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7el19nh.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35895@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).