From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:54393)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjJQ3-0004xG-8X
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:18:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjJQ1-0002v6-Vw
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:18:11 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:43499)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hjJPu-0002tu-Pw
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:18:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hjJPu-000487-63
 for guix-patches@gnu.org; Fri, 05 Jul 2019 04:18:02 -0400
Subject: [bug#36404] [PATCH v4 3/4] Add 'guix deploy'.
Resent-Message-ID: <handler.36404.B36404.156231467915866@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87o92ianbj.fsf@sdf.lonestar.org> <87o92glap5.fsf@dustycloud.org>
 <878sthoqzi.fsf@gnu.org> <87imsl9tsx.fsf_-_@sdf.lonestar.org>
 <87ef399tpu.fsf_-_@sdf.lonestar.org>
 <87a7dx9tog.fsf_-_@sdf.lonestar.org>
 <875zol9tn2.fsf_-_@sdf.lonestar.org>
 <871rz99tl9.fsf_-_@sdf.lonestar.org> <875zoldqah.fsf@kyleam.com>
 <87muhwtmfp.fsf@sdf.lonestar.org> <871rz874l2.fsf@kyleam.com>
 <877e90tj7l.fsf_-_@sdf.lonestar.org>
 <8736jotj5v.fsf_-_@sdf.lonestar.org>
 <87y31gs4k5.fsf_-_@sdf.lonestar.org>
 <87tvc4s4iv.fsf_-_@sdf.lonestar.org>
Date: Fri, 05 Jul 2019 10:17:49 +0200
In-Reply-To: <87tvc4s4iv.fsf_-_@sdf.lonestar.org> (Jakob L. Kreuze's message
 of "Tue, 02 Jul 2019 13:57:44 -0400")
Message-ID: <87a7dsopxu.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Jakob L. Kreuze" <zerodaysfordays@sdf.lonestar.org>
Cc: 36404@debbugs.gnu.org

zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:

> * guix/scripts/deploy.scm: New file.
> * Makefile.am (MODULES): Add it.

Overall LGTM, just a couple of minor points:

> +++ b/guix/scripts/deploy.scm

Please add this file to po/guix/POTFILES.in so it can be subject to
localization.

> +(define %default-options
> +  '((system . ,(%current-system))
> +    (substitutes? . #t)
> +    (build-hook? . #t)
> +    (graft? . #t)
> +    (debug . 0)
> +    (verbosity . 2)))

=E2=80=98verbosity=E2=80=99 should probably be 1 (only =E2=80=98guix build=
=E2=80=99 and =E2=80=98guix system
build=E2=80=99 default to 2.)

> +      (for-each (lambda (machine)
> +                  (format #t "building ~a... " (machine-display-name mac=
hine))
> +                  (run-with-store store (build-machine machine))
> +                  (display "done\n"))
> +                machines)
> +      (for-each (lambda (machine)
> +                  (format #t "deploying to ~a... " (machine-display-name=
 machine))
> +                  (run-with-store store (deploy-machine machine))
> +                  (display "done\n"))
> +                machines))))

For i18n purposes and also to get consistent output, please avoid
=E2=80=98format #t=E2=80=99 and instead write:

  (info (G_ "deploying ~a=E2=80=A6~%") (machine-display-name machine))

I think you can omit the =E2=80=9Cdone=E2=80=9D message.

As a matter of style, it=E2=80=99s clearer IMO to have only one =E2=80=98ru=
n-with-store=E2=80=99
call in the whole program.

Also, the separate =E2=80=98build-machine=E2=80=99 phase is not needed=E2=
=80=94more on that in
another message.

Thanks,
Ludo=E2=80=99.