From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:45311) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmPbl-0005p5-Tz for guix-patches@gnu.org; Sat, 13 Jul 2019 17:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmPbj-0007dt-K9 for guix-patches@gnu.org; Sat, 13 Jul 2019 17:31:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmPbi-0007dQ-S6 for guix-patches@gnu.org; Sat, 13 Jul 2019 17:31:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmPbi-0007To-Mr for guix-patches@gnu.org; Sat, 13 Jul 2019 17:31:02 -0400 Subject: [bug#36602] [PATCH] Add node-build-system. Resent-Message-ID: From: Jelle Licht In-Reply-To: <20190713221952.0de23569@sybil.lepiller.eu> References: <20190711184653.3f6956b8@sybil.lepiller.eu> <87ef2wsa2l.fsf@jlicht.xyz> <87a7di9kch.fsf@gnu.org> <20190713221952.0de23569@sybil.lepiller.eu> Date: Sat, 13 Jul 2019 23:30:12 +0200 Message-ID: <87a7dhsjvf.fsf@jlicht.xyz> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 36602@debbugs.gnu.org Julien Lepiller writes: > [...] > +(define* (install #:key outputs inputs #:allow-other-keys) > + "Install the node module to the output store item. MODULENAME defines > +under which name the module will be installed, GLOBAL? determines whether this > +is an npm global install." `global?' is no longer , so it could probably be removed from the docstring as well. LGTM otherwise :-).