From: Jan Nieuwenhuizen <janneke@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 36563-done@debbugs.gnu.org
Subject: bug#36563: [PATCH] guix: Add directory to channel.
Date: Sun, 14 Jul 2019 01:09:49 +0200 [thread overview]
Message-ID: <87a7dhlef6.fsf@gnu.org> (raw)
In-Reply-To: <875zo58xsv.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 13 Jul 2019 22:49:36 +0200")
Ludovic Courtès writes:
Hi!
> What about framing it along these lines:
>
> As a channel author, you may want to keep your channel modules in a
> sub-directory. In that case, blah…
>
> ?
Better, changed it to
--8<---------------cut here---------------start------------->8---
@cindex subdirectory, channels
@subsection Package Modules in a Sub-directory
As a channel author, you may want to keep your channel modules in a
sub-directory. If your modules are in the sub-directory @file{guix}, you must
add a meta-data file @file{.guix-channel} that contains:
@lisp
(channel
(version 0)
(directory "guix"))
@end lisp
--8<---------------cut here---------------end--------------->8---
> (‘read-channel-metadata’ currently ignores ‘version’, but that’s a bug
> that we should fix afterwards, IMO.)
OK.
>> + (let* ((subdir (if #$directory
>> + (string-append "/" #$directory)
>> + ""))
>> + (dir (string-append #$source subdir)))
>
> Maybe s/dir/source/?
Sure, done.
> Otherwise LGTM!
Great, thanks; pushed to master as 53f21642729e4786141c072dd835b04cb85dfe28
Greetings,
janneke
--
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com
next prev parent reply other threads:[~2019-07-13 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 19:26 [bug#36563] [PATCH] guix: Add directory to channel Jan Nieuwenhuizen
2019-07-13 10:28 ` Ludovic Courtès
2019-07-13 15:37 ` Jan Nieuwenhuizen
2019-07-13 20:49 ` Ludovic Courtès
2019-07-13 23:09 ` Jan Nieuwenhuizen [this message]
2019-07-14 13:24 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7dhlef6.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=36563-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).