From: "Ludovic Courtès" <ludo@gnu.org>
To: "Jakob L. Kreuze" <zerodaysfordays@sdf.lonestar.org>
Cc: 36555@debbugs.gnu.org
Subject: [bug#36555] [PATCH v4 2/3] guix system: Reimplement 'reconfigure'.
Date: Sat, 20 Jul 2019 16:40:54 +0200 [thread overview]
Message-ID: <87a7d86a6h.fsf@gnu.org> (raw)
In-Reply-To: <87r26lq531.fsf_-_@sdf.lonestar.org> (Jakob L. Kreuze's message of "Fri, 19 Jul 2019 13:58:26 -0400")
Hello,
zerodaysfordays@sdf.lonestar.org (Jakob L. Kreuze) skribis:
> * guix/scripts/system.scm (switch-to-system)
> (upgrade-shepherd-services, install-bootloader): Delete variable.
> * guix/scripts/system.scm (local-eval): New variable.
^
No need to repeat the file name here.
However there are other changes no mentioned here, for example changes
to the ‘install’ procedure. Could you add them to the log?
> + (install-bootloader local-eval bootloader bootcfg
> + #:target target)
> + (return
> + (format #t "bootloader successfully installed on '~a'~%"
> + (bootloader-configuration-target bootloader))))))))
While you’re at it, could you change it to:
(info (G_ "bootloader successfully installed on '~a'~%") …)
?
What happens when ‘install-bootloader’ fails though? We should make
sure that the error is diagnosed, and that the output of ‘grub-install’
or similar is shown when that happens.
> +(define (local-eval exp)
> + "Evaluate EXP, a G-Expression, in-place."
Eventually we should add it to (guix gexp).
> + (mlet* %store-monad ((lowered (lower-gexp exp))
> + (_ (built-derivations (map gexp-input-thing
> + (lowered-gexp-inputs lowered)))))
Note that there are now a few places where we call ‘built-derivations’
without calling ‘show-what-to-build*’ first. That means the UX might be
pretty bad since one has no idea what’s being built.
Furthermore, that means substitutes may not be up-to-date, leading to
many “updating substitutes” messages and HTTP round trips (as happened
with <https://issues.guix.gnu.org/issue/36509>).
Last, doing several ‘build-derivations’ call with just a couple of
derivations is less efficient than doing a single call with many
derivations; that also has an impact on the UI, if we were to call
‘show-what-to-build*’ once for ‘build-derivations’ call.
What’s your experience with this in practice?
There are several things we can do to improve on that. One is to have
‘built-derivations’ automatically call ‘show-what-to-build*’. However,
(guix derivations) must not depend on (guix ui) so we could add a
parameter to ‘run-with-store’ that would specify what to do upon
‘build-derivations’.
Last but not least, make sure to test this on your machine. :-)
It’s sensitive code that we’d rather not break.
Thanks!
Ludo’.
next prev parent reply other threads:[~2019-07-20 14:42 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 19:52 [bug#36555] [PATCH 0/2] Refactor out common behavior for system reconfiguration Jakob L. Kreuze
2019-07-08 19:59 ` [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module Jakob L. Kreuze
2019-07-08 20:01 ` [bug#36555] [PATCH 2/2] guix system: Reimplement 'reconfigure' Jakob L. Kreuze
2019-07-13 10:23 ` [bug#36555] [PATCH 1/2] guix system: Add 'reconfigure' module Ludovic Courtès
2019-07-13 17:44 ` Jakob L. Kreuze
2019-07-14 13:23 ` Ludovic Courtès
2019-07-15 15:36 ` Jakob L. Kreuze
2019-07-15 16:32 ` Ludovic Courtès
2019-07-15 23:57 ` Jakob L. Kreuze
2019-07-16 23:46 ` [bug#36555] [PATCH v3 0/3] Refactor out common behavior for system reconfiguration Jakob L. Kreuze
2019-07-16 23:47 ` [bug#36555] [PATCH v3 1/3] guix system: Add 'reconfigure' module Jakob L. Kreuze
2019-07-16 23:48 ` [bug#36555] [PATCH v3 2/3] guix system: Reimplement 'reconfigure' Jakob L. Kreuze
2019-07-16 23:48 ` [bug#36555] [PATCH v3 3/3] tests: Add reconfigure system test Jakob L. Kreuze
2019-07-19 11:57 ` [bug#36555] [PATCH v3 1/3] guix system: Add 'reconfigure' module Ludovic Courtès
2019-07-18 22:50 ` [bug#36555] [PATCH v3 0/3] Refactor out common behavior for system reconfiguration Jakob L. Kreuze
2019-07-19 17:54 ` [bug#36555] [PATCH v4 " Jakob L. Kreuze
2019-07-19 17:55 ` [bug#36555] [PATCH v4 1/3] guix system: Add 'reconfigure' module Jakob L. Kreuze
2019-07-19 17:58 ` [bug#36555] [PATCH v4 2/3] guix system: Reimplement 'reconfigure' Jakob L. Kreuze
2019-07-19 17:59 ` [bug#36555] [PATCH v4 3/3] tests: Add reconfigure system test Jakob L. Kreuze
2019-07-20 14:50 ` Ludovic Courtès
2019-07-22 18:16 ` Jakob L. Kreuze
2019-07-22 18:23 ` Jakob L. Kreuze
2019-07-22 18:54 ` [bug#36555] [PATCH v5 0/3] Refactor out common behavior for system reconfiguration Jakob L. Kreuze
2019-07-22 18:56 ` [bug#36555] [PATCH v5 1/3] guix system: Add 'reconfigure' module Jakob L. Kreuze
2019-07-22 18:57 ` [bug#36555] [PATCH v5 2/3] guix system: Reimplement 'reconfigure' Jakob L. Kreuze
2019-07-22 18:57 ` [bug#36555] [PATCH v5 3/3] tests: Add reconfigure system test Jakob L. Kreuze
2019-07-23 22:30 ` [bug#36555] [PATCH v5 2/3] guix system: Reimplement 'reconfigure' Ludovic Courtès
2019-07-24 0:06 ` Jakob L. Kreuze
2019-07-24 0:48 ` Jakob L. Kreuze
2019-07-24 16:33 ` [bug#36555] [PATCH v6 0/3] Refactor out common behavior for system reconfiguration Jakob L. Kreuze
2019-07-24 16:34 ` [bug#36555] [PATCH v6 1/3] guix system: Add 'reconfigure' module Jakob L. Kreuze
2019-07-24 16:34 ` [bug#36555] [PATCH v6 2/3] guix system: Reimplement 'reconfigure' Jakob L. Kreuze
2019-07-24 16:35 ` [bug#36555] [PATCH v6 3/3] tests: Add reconfigure system test Jakob L. Kreuze
2019-07-26 16:59 ` bug#36555: " Ludovic Courtès
2019-07-26 17:53 ` [bug#36555] " Jakob L. Kreuze
2019-07-24 22:46 ` [bug#36555] [PATCH v5 2/3] guix system: Reimplement 'reconfigure' Ludovic Courtès
2019-07-23 21:47 ` [bug#36555] [PATCH v4 3/3] tests: Add reconfigure system test Ludovic Courtès
2019-07-24 0:01 ` Jakob L. Kreuze
2019-07-24 22:44 ` Ludovic Courtès
2019-07-20 14:40 ` Ludovic Courtès [this message]
2019-07-20 14:29 ` [bug#36555] [PATCH v4 1/3] guix system: Add 'reconfigure' module Ludovic Courtès
2019-07-30 16:55 ` Jakob L. Kreuze
2019-08-23 21:00 ` Ludovic Courtès
2019-07-19 17:56 ` Jakob L. Kreuze
2019-07-19 19:36 ` [bug#36555] [PATCH v3 0/3] Refactor out common behavior for system reconfiguration Christopher Lemmer Webber
2019-07-22 16:18 ` Jakob L. Kreuze
2019-07-22 16:39 ` Christopher Lemmer Webber
2019-07-09 13:26 ` [bug#36555] [PATCH 0/2] " Christopher Lemmer Webber
2019-07-09 19:07 ` [bug#36555] [PATCH v2 0/3] " Jakob L. Kreuze
2019-07-09 19:08 ` [bug#36555] [PATCH v2 1/3] guix system: Add 'reconfigure' module Jakob L. Kreuze
2019-07-09 19:09 ` [bug#36555] [PATCH v2 2/3] guix system: Reimplement 'reconfigure' Jakob L. Kreuze
2019-07-09 19:09 ` [bug#36555] [PATCH v2 3/3] tests: Add reconfigure system test Jakob L. Kreuze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7d86a6h.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=36555@debbugs.gnu.org \
--cc=zerodaysfordays@sdf.lonestar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).