From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:36732)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i30ta-0004wv-NW
 for guix-patches@gnu.org; Wed, 28 Aug 2019 12:34:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i30tY-0005My-Nd
 for guix-patches@gnu.org; Wed, 28 Aug 2019 12:34:06 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:42337)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1i30tW-0005Lc-JD
 for guix-patches@gnu.org; Wed, 28 Aug 2019 12:34:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1i30tW-0001JS-F0
 for guix-patches@gnu.org; Wed, 28 Aug 2019 12:34:02 -0400
Subject: [bug#37138] [PATCH] gnu: Add speedcrunch.
Resent-Message-ID: <handler.37138.B37138.15670100215008@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <CA+xn8YBM84b7X=6N=oq2qrgQKkvAfHRgi2HgU3P98J86E8zW+A@mail.gmail.com>
Date: Wed, 28 Aug 2019 18:33:29 +0200
In-Reply-To: <CA+xn8YBM84b7X=6N=oq2qrgQKkvAfHRgi2HgU3P98J86E8zW+A@mail.gmail.com>
 (Steve Sprang's message of "Wed, 21 Aug 2019 17:25:41 -0700")
Message-ID: <87a7btgsh2.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Steve Sprang <steve.sprang@gmail.com>
Cc: 37138@debbugs.gnu.org

Hello Steve,

Steve Sprang <steve.sprang@gmail.com> skribis:

> From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs@stevesprang.com>
> Date: Wed, 21 Aug 2019 17:17:02 -0700
> Subject: [PATCH] gnu: Add speedcrunch.
>
> * gnu/packages/maths.scm (speedcrunch): New variable.

Nice.  A couple of comments:

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://bitbucket.org/heldercorreia/"
> +                                  "speedcrunch/get/release-" version
> +                                  ".tar.gz"))

I suspect this /get URL returns a generated tarball, whose exact content
might change over time.  If that is the case, could you instead use
=E2=80=98git-fetch=E2=80=99 (or =E2=80=98hg-fetch=E2=80=99)?

> +    (inputs `(("qt" ,qt)))

Please use =E2=80=98qtbase=E2=80=99 & co., aka. the =E2=80=9Cmodular Qt pac=
kages=E2=80=9D.  The =E2=80=98qt=E2=80=99
package is the old monolithic package and is actually deprecated.

Could you send an updated patch?

Thanks!

Ludo=E2=80=99.