unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Steve Sprang <steve.sprang@gmail.com>
Cc: 37138@debbugs.gnu.org
Subject: [bug#37138] [PATCH] gnu: Add speedcrunch.
Date: Wed, 28 Aug 2019 18:33:29 +0200	[thread overview]
Message-ID: <87a7btgsh2.fsf@gnu.org> (raw)
In-Reply-To: <CA+xn8YBM84b7X=6N=oq2qrgQKkvAfHRgi2HgU3P98J86E8zW+A@mail.gmail.com> (Steve Sprang's message of "Wed, 21 Aug 2019 17:25:41 -0700")

Hello Steve,

Steve Sprang <steve.sprang@gmail.com> skribis:

> From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001
> From: Steve Sprang <scs@stevesprang.com>
> Date: Wed, 21 Aug 2019 17:17:02 -0700
> Subject: [PATCH] gnu: Add speedcrunch.
>
> * gnu/packages/maths.scm (speedcrunch): New variable.

Nice.  A couple of comments:

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://bitbucket.org/heldercorreia/"
> +                                  "speedcrunch/get/release-" version
> +                                  ".tar.gz"))

I suspect this /get URL returns a generated tarball, whose exact content
might change over time.  If that is the case, could you instead use
‘git-fetch’ (or ‘hg-fetch’)?

> +    (inputs `(("qt" ,qt)))

Please use ‘qtbase’ & co., aka. the “modular Qt packages”.  The ‘qt’
package is the old monolithic package and is actually deprecated.

Could you send an updated patch?

Thanks!

Ludo’.

  reply	other threads:[~2019-08-28 16:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  0:25 [bug#37138] [PATCH] gnu: Add speedcrunch Steve Sprang
2019-08-28 16:33 ` Ludovic Courtès [this message]
2019-08-28 20:58   ` Steve Sprang
2019-08-31 18:58     ` bug#37138: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7btgsh2.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37138@debbugs.gnu.org \
    --cc=steve.sprang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).