From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:36225) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPPUl-0002Z6-FR for guix-patches@gnu.org; Tue, 29 Oct 2019 07:17:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPPOw-0005tA-Qs for guix-patches@gnu.org; Tue, 29 Oct 2019 07:11:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38115) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPPOw-0005t4-Nr for guix-patches@gnu.org; Tue, 29 Oct 2019 07:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPPOw-0003in-F5 for guix-patches@gnu.org; Tue, 29 Oct 2019 07:11:02 -0400 Subject: [bug#37975] [PATCH 2/2] gnu: Add udiskie. Resent-Message-ID: From: Pierre Neidhardt References: <87r22v6gxv.fsf@yamatai> <20191029093135.32727-1-glv@posteo.net> <20191029093135.32727-2-glv@posteo.net> Date: Tue, 29 Oct 2019 12:10:15 +0100 In-Reply-To: <20191029093135.32727-2-glv@posteo.net> (Guillaume Le Vaillant's message of "Tue, 29 Oct 2019 10:31:35 +0100") Message-ID: <87a79jerjc.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Guillaume Le Vaillant Cc: 37975@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Guillaume, Looking great, just a few nits below: > + (arguments > + `(;; The tests want libappindicator, which is not available. Why isn't available? Should we package it? URL of the lib? > + #:tests? #f > + #:phases > + (modify-phases %standard-phases > + (add-after 'install 'wrap-gi-typelib > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out")) > + (gi-typelib-path (getenv "GI_TYPELIB_PATH"))) > + (wrap-program (string-append out "/bin/udiskie") > + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))) > + #t))))) > + (home-page "https://github.com/coldfix/udiskie") > + (synopsis "Automounter for removable media") > + (description > + "The udiskie program is a udisks2 front-end that allows to manage @command{udiskie}. > +removeable media such as CDs or flash drives from userspace. Typo: removable. > + > +Its features include: > + > +@itemize > +@item automount removable media > +@item notifications > +@item tray icon > +@item command line tools for manual un-/mounting I find the "-/" syntax a bit unconventional. Maybe "(un)mounting" would be better. In doubt, "mounting and unmounting" works in all cases :) > +@item LUKS encrypted devices > +@item unlocking with keyfiles > +@item loop devices (mounting iso archives) iso =3D> ISO > +@item password caching > +@end itemize") =3D> @end itemize\n Also maybe improve the typography of the list, e.g. add commas at the end of every line and a period for the last line. =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl24HhcACgkQm9z0l6S7 zH+RoQf7BbufoR8W6nX0gTbqlgobWjgwM4Okdus214jVF14vE3wk7kzhB7T3tQED 9iVQaic/uPnrlH0zx2Rc+/wRxCRL59g0ZMxzhKmRkZt+wVHAT5biX8e2fQayPZ4s GzeJcJko4qHk0KCwm2kJVupZvMC0zrKleUMc304K3n2+W/KJSUSZWmPxMPvX7cAS Drmr6EfWObBBBzT3ldixUJuWjdIegF5UZxtQqFzXtdmJ5QjVMjL/6IJWb9oyrKOq Qg8fUZlTa5KPXAV5MYdNGsls0s7ctZz4/lblDdSF1heNLzscxwBnoDMTV/eeDudl dk+mMJWh9/AxdgmbsuB1W9c4OZHg3Q== =vVqk -----END PGP SIGNATURE----- --=-=-=--