[bug#37975] [PATCH 2/2] gnu: Add udiskie.

[Pierre Neidhardt <mail@ambrevar.xyz>]

[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]

Hi Guillaume,

Looking great, just a few nits below:

> +    (arguments
> +     `(;; The tests want libappindicator, which is not available.

Why isn't available?  Should we package it?  URL of the lib?

> +       #:tests? #f
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'wrap-gi-typelib
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out"))
> +                   (gi-typelib-path (getenv "GI_TYPELIB_PATH")))
> +               (wrap-program (string-append out "/bin/udiskie")
> +                 `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))
> +             #t)))))
> +    (home-page "https://github.com/coldfix/udiskie")
> +    (synopsis "Automounter for removable media")
> +    (description
> +     "The udiskie program is a udisks2 front-end that allows to manage

@command{udiskie}.

> +removeable media such as CDs or flash drives from userspace.

Typo: removable.

> +
> +Its features include:
> +
> +@itemize
> +@item automount removable media
> +@item notifications
> +@item tray icon
> +@item command line tools for manual un-/mounting

I find the "-/" syntax a bit unconventional.  Maybe "(un)mounting" would be
better.
In doubt, "mounting and unmounting" works in all cases :)

> +@item LUKS encrypted devices
> +@item unlocking with keyfiles
> +@item loop devices (mounting iso archives)

iso => ISO

> +@item password caching
> +@end itemize")

=> @end itemize\n

Also maybe improve the typography of the list, e.g. add commas at the
end of every line and a period for the last line.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]