[bug#38103] Dracula emacs theme

[bug#38103] Dracula emacs theme

[bluekeys]

Hi,

The attached patch adds the dracula emacs theme to emacs-xyz.scm
My first patch to free software.

Feedback welcome!

<#part type="text/x-patch" filename="~/src/guix/0001-Create-emacs-dracula-theme-module.patch" disposition=inline description="emacs-dracula-theme patch">
<#/part>

David

[bug#38103] Dracula emacs theme

[Mathieu Othacehe]

Hello!

> The attached patch adds the dracula emacs theme to emacs-xyz.scm
> My first patch to free software.

Welcome! And thanks for this first contribution :)

Regarding the patch, I think you have a problem with your mailer, I can
only see:

> < #part type="text/x-patch" filename="~/src/guix/0001-Create-emacs-dracula-theme-module.patch" disposition=inline description="emacs-dracula-theme patch">
> < #/part>

and not the patch itself.

Mathieu

[bug#38103] Dracula emacs theme

[bluekeys]

[-- Attachment #1: Type: text/plain, Size: 43 bytes --]

Hi,

Second attempt to attach the patch. 


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dracula theme --]
[-- Type: text/x-patch, Size: 1499 bytes --]

From ef1394d995e1eb180c6cc51974aa82d42c7d67e5 Mon Sep 17 00:00:00 2001
From: bluekeys <git@bluekeys.eu>
Date: Tue, 5 Nov 2019 22:31:43 +0000
Subject: [PATCH] Create emacs-dracula-theme module

---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1be819728f..d04ae3d26a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8050,6 +8050,26 @@ known loosely as deftheme.  Many mode-specific customizations are included.")
        "@code{danneskjold-theme} is a high-contrast theme for Emacs.")
       (license license:gpl3+))))
 
+(define-public emacs-dracula-theme
+  (package
+    (name "emacs-dracula-theme")
+    (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/dracula/emacs.git")
+             (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517")))
+       (sha256
+        (base32
+         "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn"))))
+    (build-system emacs-build-system)
+    (home-page "https://draculatheme.com/emacs")
+    (synopsis "A dark theme for emacs")
+    (description
+     "A dark theme for emacs and 50+ apps")
+    (license license:expat)))
+
 (define-public emacs-dream-theme
   (let* ((commit "107a11d74365046f28a1802a2bdb5e69e4a7488b")
          (revision "1"))
-- 
2.23.0

[bug#38103] Dracula emacs theme

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]

bluekeys@bluekeys.eu writes:

> Hi,
>
> Second attempt to attach the patch. 

Looks good!

[...]
  
> +(define-public emacs-dracula-theme
> +  (package
> +    (name "emacs-dracula-theme")
> +    (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/dracula/emacs.git")
> +             (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517")))

Could add a (let (commit ...)) binding for the commit hash so we don't
have to repeat it twice?  See the surrounding packages for examples.

Please also add a 'file-name' field here.

> +       (sha256
> +        (base32
> +         "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://draculatheme.com/emacs")
> +    (synopsis "A dark theme for emacs")

Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'.

> +    (description
> +     "A dark theme for emacs and 50+ apps")

Can you expand a bit on the "50+ apps" part?  Perhaps something along
the lines of "Dracula is a dark color theme implemented for more than 50
different applications.  This package provides the Emacs theme."

Can you send an updated patch?  Thanks, and welcome!  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38103] Dracula emacs theme

[Brett Gilio]

Marius Bakke <mbakke@fastmail.com> writes:

> bluekeys@bluekeys.eu writes:
>
>> Hi,
>>
>> Second attempt to attach the patch. 
>
> Looks good!
>
> [...]
>   
>> +(define-public emacs-dracula-theme
>> +  (package
>> +    (name "emacs-dracula-theme")
>> +    (version (git-version "0" "0" "320cc8cfc67e33c86045ef3e79b7627b91b9b517"))
>> +    (source
>> +     (origin
>> +       (method git-fetch)
>> +       (uri (git-reference
>> +             (url "https://github.com/dracula/emacs.git")
>> +             (commit "320cc8cfc67e33c86045ef3e79b7627b91b9b517")))
>
> Could add a (let (commit ...)) binding for the commit hash so we don't
> have to repeat it twice?  See the surrounding packages for examples.
>
> Please also add a 'file-name' field here.
>
>> +       (sha256
>> +        (base32
>> +         "0pzlwxsa823sbcf2nq2lw303cld2jc2siaaiafld0qc4xasg9zyn"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://draculatheme.com/emacs")
>> +    (synopsis "A dark theme for emacs")
>
> Just "Dark theme for Emacs", to appease 'guix lint emacs-dracula-theme'.
>
>> +    (description
>> +     "A dark theme for emacs and 50+ apps")
>
> Can you expand a bit on the "50+ apps" part?  Perhaps something along
> the lines of "Dracula is a dark color theme implemented for more than 50
> different applications.  This package provides the Emacs theme."
>
> Can you send an updated patch?  Thanks, and welcome!  :-)
>

Hi Marius and bluekeys!

I just wanted to bump this so we can get it pushed. If you would like
some help, bluekeys please do not hesitate to ask us either here or on
the #guix Freenode IRC.

Also, when you send your revised patch do include yourself in the
copyright section of the header! You deserve that designation for your
contribution.

Thanks!

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

bug#38103: Dracula emacs theme

[Michael Rohleder]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

close 38103

this has been added recently.
-- 
Lady Nancy Astor: "Winston, if you were my husband, I'd put poison in your coffee."
Winston Churchill: "Nancy, if you were my wife, I'd drink it."

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]