unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: Alexandros Theodotou <alex@zrythm.org>, 38127@debbugs.gnu.org
Subject: [bug#38127] [PATCH] gnu: Add x42-plugins.
Date: Sun, 10 Nov 2019 23:00:03 +0100	[thread overview]
Message-ID: <87a793l7do.fsf@devup.no> (raw)
In-Reply-To: <452ecadc3842a20e4e6c768649855525@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> NOTE: this patch depends on
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38121 and
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38126
>  From ee2e983068b3dd11aaed7c703388904749e77a44 Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 10:54:00 +0000
> Subject: [PATCH] gnu: Add x42-plugins.
>
> * gnu/packages/music.scm: (x42-plugins): New variable.

The patch LGTM overall, but indentation seems to be off.  Can you run
this through "./etc/indent-code.el"?

[...]

> +    (synopsis "Collection of LV2/JACK audio/MIDI processing plugins")
> +    (description "x42-plugins is a collection of over 80 cross-platform 
> LV2
> +audio and MIDI plugins that can also run as standalone JACK 
> applications.")
> +    (home-page "https://x42-plugins.com/x42/")
> +    (license license:gpl2+)))

I notice in the FAQ that "Some binaries are provided as demo.  A
license/signature file is required to remove the evaluation
restrictions".

If there are such binaries in the source tarball, they must be removed
with a source 'snippet' to ensure 'guix build --source' contains only
free software.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2019-11-10 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 10:55 [bug#38127] [PATCH] gnu: Add x42-plugins Alexandros Theodotou
2019-11-10 22:00 ` Marius Bakke [this message]
2019-11-11  1:53   ` Alexandros Theodotou
2019-11-13 22:26     ` bug#38127: " Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a793l7do.fsf@devup.no \
    --to=mbakke@fastmail.com \
    --cc=38127@debbugs.gnu.org \
    --cc=alex@zrythm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).