From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:52482)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iku0u-0004Aa-1T
 for guix-patches@gnu.org; Fri, 27 Dec 2019 13:07:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iku0s-0006Do-CL
 for guix-patches@gnu.org; Fri, 27 Dec 2019 13:07:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:51797)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iku0s-0006DT-7U
 for guix-patches@gnu.org; Fri, 27 Dec 2019 13:07:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iku0s-00006f-1t
 for guix-patches@gnu.org; Fri, 27 Dec 2019 13:07:02 -0500
Subject: [bug#38612] Pass system and target arguments to gexp->file.
Resent-Message-ID: <handler.38612.B38612.1577469982358@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com>
 <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com>
 <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org>
 <87mubej4sq.fsf@gmail.com>
Date: Fri, 27 Dec 2019 19:05:55 +0100
In-Reply-To: <87mubej4sq.fsf@gmail.com> (Mathieu Othacehe's message of "Thu,
 26 Dec 2019 19:54:45 +0100")
Message-ID: <87a77dhce4.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 38612@debbugs.gnu.org

Hello!

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

>> In general, in monadic code, we should refer to (current-system) and
>> (current-target-system), not to the SRFI-39 parameters.
>
> Ok!
>
>> By default, =E2=80=98gexp->file=E2=80=99 now uses the current system and=
 target, so this
>> change shouldn=E2=80=99t be necessary if you just want to use those.  Am=
 I
>> missing something?
>
> Well turns out that gexp->file takes #f as default target (as
> gexp->script and lower-object).

Oh, right.

> Using %current-target-system as default target argument (as gexp->sexp)
> makes those two patches useless.
>
> Would you have any objection to use %current-target-system as default
> target argument in gexp->file and lower-object?

As written above, it should default to =E2=80=98current-target-system=E2=80=
=99 rather
than =E2=80=98%current-target-system=E2=80=99.  Kind of annoying, but heh=
=E2=80=A6

Also, we should probably get rid of the monadic style in (gnu services).
That would simplify things, but there are compatibility considerations=E2=
=80=A6

Thanks,
Ludo=E2=80=99.