From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:42433) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9wyR-0002sL-Tw for guix-patches@gnu.org; Thu, 05 Mar 2020 15:20:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9wyQ-0001rr-Nd for guix-patches@gnu.org; Thu, 05 Mar 2020 15:20:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9wyQ-0001rk-KY for guix-patches@gnu.org; Thu, 05 Mar 2020 15:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9wyQ-0005xY-Bp for guix-patches@gnu.org; Thu, 05 Mar 2020 15:20:02 -0500 Subject: [bug#39931] [PATCH] gnu: Added emacs-org-journal Resent-Message-ID: From: Nicolas Goaziou References: <20200305174723.15314-1-mjbecze@riseup.net> Date: Thu, 05 Mar 2020 21:18:52 +0100 In-Reply-To: <20200305174723.15314-1-mjbecze@riseup.net> (Martin Becze's message of "Thu, 5 Mar 2020 12:47:23 -0500") Message-ID: <87a74uk11v.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Martin Becze Cc: 39931@debbugs.gnu.org Hello, Martin Becze writes: > * gnu/packages/emacs-xyz.scm (emacs-org-journal): New Variable. Thank you! > +(define-public emacs-org-journal > + (package > + (name "emacs-org-journal") > + (version "2.0.0") > + (home-page "https://github.com/bastibe/org-journal") Usually, `home-page' is lower in the package definition, right above `synop= sis'. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url home-page) It may be just me, but I'm not a big fan of this trick, because it binds two information that might be unrelated at some point. I suggest to use the full URL instead. OTOH, the above is not a strong argument either, so it's up to you. > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "18dqd0jy2x530lk0h4fcn9cld9qh4w7b3vxa60fpiia628vsv1dg")))) > + (build-system emacs-build-system) > + (synopsis "A simple org-mode based journaling mode") I suggest "Simple Org mode based journaling mode". In any case, I think "guix lint" complains when a synopsis starts with an article. > + (description "@code{org-journal} maintains a set of files, depending= on the value > + of @{org-journal-file-type}, a file represents a day, week, month or ye= ar. When > +@code{org-journal-file-type} is set to =3D=E2=80=99daily=3D, each file r= epresent a day. In case > +@{org-journal-file-type} is set to =3D=E2=80=99weekly=3D, a file represe= nts > a week, etc. "Org Journal maintains a set of files, which may represent a day, a week, a month or a year." IOW, I think description should not leak the innards of the package. > + Convenient bindings allow the creation of journal records in the curren= t daily, > + weekly, monthly or yearly file and search within all records or specifi= ed time > + intervals. All records can be browsed and searched from the Emacs Calen= dar for > + convenience.") You need to add two spaces after full stops. Could you send an updated patch? Regards, --=20 Nicolas Goaziou