From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34224) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRJ6U-0006z1-IV for guix-patches@gnu.org; Wed, 22 Apr 2020 13:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRJ6Q-0004NS-Ay for guix-patches@gnu.org; Wed, 22 Apr 2020 13:24:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRJ6P-0004MK-Ve for guix-patches@gnu.org; Wed, 22 Apr 2020 13:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRJ6P-0000dX-Rb for guix-patches@gnu.org; Wed, 22 Apr 2020 13:24:01 -0400 Subject: [bug#40492] [PATCH] gnu: Add meshlab Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <_UXapokzwPRYl41j0bjkPGSDUNXahWNWsEn72py7ch7Rd6DBsxW9B8rw8wTbmzj1O2HfWXz7XLbEdWCYQsFCa5DgMlGn0CKVPr779J2PFuo=@elenq.tech> Date: Wed, 22 Apr 2020 19:23:38 +0200 In-Reply-To: <_UXapokzwPRYl41j0bjkPGSDUNXahWNWsEn72py7ch7Rd6DBsxW9B8rw8wTbmzj1O2HfWXz7XLbEdWCYQsFCa5DgMlGn0CKVPr779J2PFuo=@elenq.tech> (Ekaitz Zarraga's message of "Tue, 07 Apr 2020 17:08:06 +0000") Message-ID: <87a733v3hh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ekaitz Zarraga Cc: 40492@debbugs.gnu.org Hi, Ekaitz Zarraga skribis: > I wrote a package to add meshlab but I'm not sure if I did it right: > - It doesn't have tests so I removed the testing. Please add a short comment in the code saying this so that people touching the package in the future will know. > - It fails to check RUNPATH, but I don't really know why so I disabled > it at the moment. It fails while searching for meshlab core libraries > but the search path is correct (it misses a /meshlab at the end). Could you show the error message? It may be that the build system fails to pass the right -Wl,-rpath or even the right -L/-l flags at link time. >>>From d9020d7e64020dc7eea1bd46af184856d568ca7d Mon Sep 17 00:00:00 2001 > From: Ekaitz Zarraga > Date: Tue, 7 Apr 2020 18:56:06 +0200 > Subject: [PATCH] gnu: Add meshlab > > --- > gnu/packages/engineering.scm | 39 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) Bonus points if you can provide a commit log that follows our conventions. :-) See and =E2=80=98git log=E2=80=99 for examples. > +(define-public meshlab > + (let ((commit-ref "Meshlab-2020.04")) > + (package > + (name "meshlab") > + (version commit-ref) The version field should be =E2=80=9C2020.04=E2=80=9D. You can construct t= he commit from that: (string-append "Meshlab-" version) > + (synopsis > + "The open source system for processing and editing 3D triangular= meshes.") > + (home-page "http://www.meshlab.net/") > + (description "MeshLab is an open source, portable, and extensible = system Two comments: 1. Everything in Guix is free software, you can remove the =E2=80=9Copen source=E2=80=9D mention. 2. Please make sure to run =E2=80=98guix lint=E2=80=99 and check the guid= elines at . Could you send an updated patch? Thanks in advance! Ludo=E2=80=99.